Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add support for OpenTelemetry metrics to Connection API #2896

Merged
merged 2 commits into from
Feb 27, 2024
Merged

chore: add support for OpenTelemetry metrics to Connection API #2896

merged 2 commits into from
Feb 27, 2024

Conversation

hengfengli
Copy link
Contributor

Adds support for OpenTelemetry metrics in the Connection API.

@hengfengli hengfengli requested a review from a team as a code owner February 19, 2024 07:16
@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: spanner Issues related to the googleapis/java-spanner API. labels Feb 19, 2024
@hengfengli hengfengli force-pushed the support-otel-in-conn-api branch 2 times, most recently from 518a1f4 to fa2c795 Compare February 22, 2024 23:23
@product-auto-label product-auto-label bot added size: s Pull request size is small. and removed size: m Pull request size is medium. labels Feb 22, 2024
@product-auto-label product-auto-label bot added size: m Pull request size is medium. and removed size: s Pull request size is small. labels Feb 23, 2024
olavloite
olavloite approved these changes Feb 26, 2024
View reviewed changes
Copy link
Collaborator

@olavloite olavloite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, except for the comment on what to do when no OpenTelemetry has been set. I think that we should just return null, and let SpannerOptions determine the default.

google-cloud-spanner/src/main/java/com/google/cloud/spanner/connection/ConnectionOptions.java Outdated Show resolved Hide resolved
@olavloite olavloite added the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 27, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 27, 2024
@hengfengli hengfengli requested a review from a team as a code owner February 27, 2024 09:35
@olavloite olavloite merged commit 4f7d28b into googleapis:main Feb 27, 2024
25 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olavloite olavloite olavloite approved these changes

Assignees
No one assigned
Labels
api: spanner Issues related to the googleapis/java-spanner API. size: m Pull request size is medium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hengfengli @olavloite