Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Change policy member in SetPolicy examples #1943

Merged
merged 4 commits into from
Mar 7, 2024

Conversation

michaelpri10
Copy link
Contributor

@michaelpri10 michaelpri10 commented Mar 7, 2024

This updates the member in the Binding for SetTopicPolicyExample and SetSubscriptionPolicyExample to fix a failure in the AdminIT test for the GCP project used for testing.

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

If you write sample code, please follow the samples format.

@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: pubsub Issues related to the googleapis/java-pubsub API. size: s Pull request size is small. and removed size: xs Pull request size is extra small. labels Mar 7, 2024
@suztomo
Copy link
Member

suztomo commented Mar 7, 2024

I see the sample builds both in Kokoro and Cloud Build succeeded. Thank you.

Screenshot 2024-03-07 at 12 13 44 PM

@michaelpri10 michaelpri10 added the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 7, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 7, 2024
@michaelpri10 michaelpri10 requested review from a team as code owners March 7, 2024 17:18
@michaelpri10 michaelpri10 merged commit 3780815 into googleapis:main Mar 7, 2024
23 checks passed
suztomo added a commit to googleapis/java-storage that referenced this pull request Mar 13, 2024
sydney-munro added a commit to googleapis/java-storage that referenced this pull request Mar 27, 2024
* ci: sample build in Cloud Build

* empty commit to trigger Cloud Build

* adding the service account email

* ci: test CI

* domain:google.com

Following googleapis/java-pubsub#1943

* service account

* format

* using the samples@ account

* ci: test CI

* empty commit to trigger Cloud Build after b/329758593

* project number as env var

* Available binding identities

* sample id

* stop introducing a new env var for Kokoro

* chore: switch kms keys to point to new project keys

* lint

* remove unnecessary ;

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

---------

Co-authored-by: Sydney Munro <[email protected]>
Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: pubsub Issues related to the googleapis/java-pubsub API. size: s Pull request size is small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants