Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

samples: fix sample versions and clean up resource #2196

Merged
merged 3 commits into from
Apr 13, 2024
Merged

samples: fix sample versions and clean up resource #2196

merged 3 commits into from
Apr 13, 2024

Conversation

mutianf
Copy link
Contributor

@mutianf mutianf commented Apr 12, 2024

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)
  • Rollback plan is reviewed and LGTMed
  • All new data plane features have a completed end to end testing plan

Fixes #<issue_number_goes_here> ☕️

If you write sample code, please follow the samples format.

@mutianf mutianf requested review from a team as code owners April 12, 2024 19:29
@snippet-bot Snippet Bot
Copy link

snippet-bot bot commented Apr 12, 2024 •
edited

No region tags are edited in this PR.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@product-auto-label product-auto-label bot added the size: s Pull request size is small. label Apr 12, 2024
@generated-files-bot Generated Files Bot
Copy link

Warning: This pull request is touching the following templated files:

  • samples/install-without-bom/pom.xml
  • samples/snippets/pom.xml

@product-auto-label product-auto-label bot added api: bigtable Issues related to the googleapis/java-bigtable API. samples Issues that are directly related to samples. labels Apr 12, 2024
@mutianf
Copy link
Contributor Author

mutianf commented Apr 12, 2024

/gcbrun

@mutianf mutianf added the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 12, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 12, 2024
@mutianf
Copy link
Contributor Author

mutianf commented Apr 12, 2024

/gcbrun

@mutianf mutianf added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 12, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 12, 2024
@mutianf mutianf merged commit 3c44e18 into googleapis:main Apr 13, 2024
20 of 21 checks passed
@mutianf mutianf deleted the fix-sample branch April 13, 2024 00:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@igorbernstein2 igorbernstein2 igorbernstein2 approved these changes

Assignees

@kweinmeister kweinmeister

Labels
api: bigtable Issues related to the googleapis/java-bigtable API. samples Issues that are directly related to samples. size: s Pull request size is small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mutianf @igorbernstein2 @kweinmeister @yoshi-kokoro