Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Rewrite SampleRowKeys IT on AuthorizedView #2187

Merged
merged 2 commits into from
Mar 28, 2024
Merged

Conversation

trollyxia
Copy link
Member

Change-Id: I37927d1b0a3502f6554e575ac44d4d92417d7d26

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)
  • Rollback plan is reviewed and LGTMed
  • All new data plane features have a completed end to end testing plan

Fixes #<issue_number_goes_here> ☕️

If you write sample code, please follow the samples format.

@trollyxia trollyxia requested review from a team as code owners March 28, 2024 13:46
@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: bigtable Issues related to the googleapis/java-bigtable API. labels Mar 28, 2024
@mutianf
Copy link
Contributor

mutianf commented Mar 28, 2024

lgtm but please reformat the code with mvn com.coveo:fmt-maven-plugin:format

Change-Id: I37927d1b0a3502f6554e575ac44d4d92417d7d26
@mutianf mutianf added the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 28, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 28, 2024
@trollyxia trollyxia requested a review from a team as a code owner March 28, 2024 14:30
@mutianf mutianf merged commit 3ccd8fc into googleapis:main Mar 28, 2024
20 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigtable Issues related to the googleapis/java-bigtable API. size: m Pull request size is medium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants