Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Support AuthorizedView in bigtable data client #2177

Merged
merged 3 commits into from
Mar 27, 2024
Merged

feat: Support AuthorizedView in bigtable data client #2177

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
512818e
feat: Support AuthorizedView in bigtable data client
Mar 20, 2024
c0d05d8
Fix extractTableId() and add a unit test for it
Mar 27, 2024
4fd09d6
Mark SampleRowKeysRequest#fromProto as @InternalApi
Mar 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
Prev Previous commit
Mark SampleRowKeysRequest#fromProto as @internalapi 
Change-Id: I71762fad534fe31f4bf634ca5cb227f014393e37
  • Loading branch information
Lixia Chen committed Mar 27, 2024
commit 4fd09d680861a968788cd41cf3296f176185b329
1 change: 1 addition & 0 deletions ...bigtable/src/main/java/com/google/cloud/bigtable/data/v2/models/SampleRowKeysRequest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,7 @@ public com.google.bigtable.v2.SampleRowKeysRequest toProto(RequestContext reques
* <p>WARNING: Please note that the project id & instance id in the table/authorized view name
* will be overwritten by the configuration in the BigtableDataClient.
*/
@InternalApi
public static SampleRowKeysRequest fromProto(
mutianf marked this conversation as resolved.
Show resolved Hide resolved
@Nonnull com.google.bigtable.v2.SampleRowKeysRequest request) {
String tableName = request.getTableName();
Expand Down