Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update the accounting of partial batch mutations #2149

Merged
merged 32 commits into from
Mar 27, 2024
Merged
Changes from 1 commit
Commits
Show all changes
32 commits
Select commit Hold shift + click to select a range
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
Prev Previous commit
Next Next commit
fix tests
  • Loading branch information
ron-gal committed Mar 7, 2024
commit f0f4e073128d92b22ba21cdccaea19c7301ddc87
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,9 @@ public boolean shouldRetry(
if (retryAlgorithm.shouldRetry(previousThrowable, previousResponse)) {
return true;
}
if (previousResponse == null) {
return false;
}
return previousResponse.isRetryable;
}

Expand All @@ -67,6 +70,9 @@ public boolean shouldRetry(
if (retryAlgorithm.shouldRetry(context, previousThrowable, previousResponse)) {
igorbernstein2 marked this conversation as resolved.
Show resolved Hide resolved
return true;
}
if (previousResponse == null) {
return false;
}
return previousResponse.isRetryable;
}
}