Skip to content

Commit

Permalink
fix: Make ChangeStreamRecord interface serializable (#1685)
Browse files Browse the repository at this point in the history
Make ChangeStreamRecord interface Serializable so that beam can create Coders for it by default.  ChangeStreamMutation, CloseStream, and Heartbeat all already implement Serializable.

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
- [ ] Make sure to open an issue as a [bug/issue](https://togithub.com/googleapis/java-bigtable/issues/new/choose) before writing your code!  That way we can discuss the change, evaluate designs, and agree on the general idea
- [ ] Ensure the tests and linter pass
- [ ] Code coverage does not decrease (if any source code was changed)
- [ ] Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> ☕️

If you write sample code, please follow the [samples format](
https://togithub.com/GoogleCloudPlatform/java-docs-samples/blob/main/SAMPLE_FORMAT.md).
  • Loading branch information
jackdingilian committed Mar 29, 2023
1 parent c39a36a commit b97badb
Showing 1 changed file with 2 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -16,10 +16,11 @@
package com.google.cloud.bigtable.data.v2.models;

import com.google.api.core.InternalApi;
import java.io.Serializable;

/**
* Default representation of a change stream record, which can be a Heartbeat, a CloseStream, or a
* logical mutation.
*/
@InternalApi("Intended for use by the BigtableIO in apache/beam only.")
public interface ChangeStreamRecord {}
public interface ChangeStreamRecord extends Serializable {}

0 comments on commit b97badb

Please sign in to comment.