Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: drop support for PHP 7.4 #7076

Merged
merged 13 commits into from
Feb 28, 2024
Merged

chore: drop support for PHP 7.4 #7076

merged 13 commits into from
Feb 28, 2024

Conversation

bshaffer
Copy link
Contributor

@bshaffer bshaffer commented Feb 20, 2024

  • Also add support for psr/log:v3 in google/cloud-logging

BREAKING_CHANGE_REASON=we have upgraded to PSR Log v3, which has added typehinting. The new typehints do not change behavior, and therefore should not break anything.

Closes #6984

@bshaffer bshaffer requested review from a team as code owners February 20, 2024 18:59
@bshaffer bshaffer added the next release PRs to be included in the next release label Feb 23, 2024
@@ -26,7 +26,7 @@ jobs:
- name: Setup PHP
uses: shivammathur/setup-php@v2
with:
php-version: '7.4'
php-version: '8.1'
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

incrementing emulators to 8.1 since we'll be dropping php 8.0 in May so we might as well do it now

Copy link
Contributor

@shivgautam shivgautam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bshaffer bshaffer merged commit e00e8fe into main Feb 28, 2024
30 checks passed
@bshaffer bshaffer deleted the drop-php74 branch February 28, 2024 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
next release PRs to be included in the next release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants