Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(storage): Implement io.WriterTo in Reader #9659

Merged
merged 5 commits into from
Mar 28, 2024

Commits on Mar 28, 2024

  1. feat(storage): Implement io.WriterTo in Reader

    This allows the gRPC Reader to write directly into the application
    write buffer, saving a data copy.
    
    Users can get the benefit of this directly by explicitly calling
    Reader.WriteTo, but they can also benefit implicitly if they are
    calling io.Copy.
    
    A bunch of checksum logic had to be moved from the parent Reader
    into the transport Readers to make this work, since we need to
    update the checksum for every message read in WriteTo.
    tritone committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    b1620ca View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    4620944 View commit details
    Browse the repository at this point in the history
  3. fix conf test object vars

    tritone committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    61d27ff View commit details
    Browse the repository at this point in the history
  4. fix review comments

    tritone committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    45d0180 View commit details
    Browse the repository at this point in the history
  5. fix EOF case.

    tritone committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    202c9c0 View commit details
    Browse the repository at this point in the history