Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(bigquery/storage/managedwriter): retry improvements #9642

Merged
merged 2 commits into from
Mar 25, 2024
Merged

fix(bigquery/storage/managedwriter): retry improvements #9642

merged 2 commits into from
Mar 25, 2024

Commits on Mar 25, 2024

  1. fix(bigquery/storage/managedwriter): retry improvements 

    This PR makes two changes to retry behaviors in managedwriter.

In the first, this PR expands the set of conditions that trigger
reconnect when sending the initial request to the backend.

In the second, this PR adds some additional handling for context
cancellations when reading responses back from the service.  In
cases like reconnection, we establish a new Connection, each of
which has it's own associated context.  When draining remaining
writes from a connection that's being shut down, we now pass the
write into a retryer with a status-based error rather than raw
context.Canceled, so we can recover more cleanly if the user is
leveraging write retries.

Related internal issue:
b/326242484
    @shollyman
    shollyman committed Mar 25, 2024
    Configuration menu
    Copy the full SHA
    ac85bcc View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into retry-testing

    @shollyman
    shollyman committed Mar 25, 2024
    Configuration menu
    Copy the full SHA
    d83ab3e View commit details
    Browse the repository at this point in the history