Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(storage): retry errors from last recv on uploads #9616

Merged
merged 4 commits into from
Mar 21, 2024
Merged

fix(storage): retry errors from last recv on uploads #9616

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e2be77b
fix(storage): retry errors from last recv on uploads
BrennaEpp Mar 20, 2024
eecbc77
comment
BrennaEpp Mar 20, 2024
520310f
Merge branch 'main' into fix-grpc-retry
BrennaEpp Mar 20, 2024
cc5241a
Merge branch 'main' into fix-grpc-retry
BrennaEpp Mar 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
Prev Previous commit
Next Next commit
comment
  • Loading branch information
@BrennaEpp
BrennaEpp committed Mar 20, 2024
commit eecbc77f0e6e9aba0175841af4352afadf533994
2 changes: 1 addition & 1 deletion storage/grpc_client.go
View file
Open in desktop
Expand Up @@ -1872,7 +1872,7 @@ func (w *gRPCWriter) uploadBuffer(recvd int, start int64, doneReading bool) (*st

// Send a request with as many bytes as possible.
// Loop until all bytes are sent.
sendBytes:
sendBytes: // label this loop so that we can use a continue statement from a nested block
for {
bytesNotYetSent := recvd - sent
remainingDataFitsInSingleReq := bytesNotYetSent <= maxPerMessageWriteSize
Expand Down