Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(spanner): add JSON_PARSE_ARRAY to funcNames slice #9557

Merged
merged 2 commits into from
Mar 13, 2024
+48 −0
Merged

fix(spanner): add JSON_PARSE_ARRAY to funcNames slice #9557

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dd64f92
fix(spanner): add JSON_PARSE_ARRAY to funcNames slice
kai5263499 Mar 12, 2024
77cb3d6
Merge branch 'main' into add_JSON_VALUE_ARRAY_to_parser
rahul2393 Mar 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
Next Next commit
fix(spanner): add JSON_PARSE_ARRAY to funcNames slice
  • Loading branch information
@kai5263499
kai5263499 committed Mar 12, 2024
commit dd64f9266c0ff50fbe2f07affd47713d387b1320
3 changes: 3 additions & 0 deletions spanner/spansql/keywords.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -277,7 +277,10 @@ var funcNames = []string{
"PENDING_COMMIT_TIMESTAMP",

// JSON functions.
"JSON_QUERY",
"JSON_VALUE",
"JSON_QUERY_ARRAY",
"JSON_VALUE_ARRAY",

// Bit functions.
"BIT_COUNT",
Expand Down
45 changes: 45 additions & 0 deletions spanner/spansql/parser_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1431,6 +1431,21 @@ func TestParseDDL(t *testing.T) {
},
},
},
{`ALTER TABLE products ADD COLUMN item STRING(MAX) AS (JSON_QUERY(itemDetails, '$.itemDetails')) STORED`, &DDL{Filename: "filename", List: []DDLStmt{
&AlterTable{
Name: "products",
Alteration: AddColumn{Def: ColumnDef{
Name: "item",
Type: Type{Base: String, Len: MaxLen},
Position: line(1),
Generated: Func{
Name: "JSON_QUERY",
Args: []Expr{ID("itemDetails"), StringLiteral("$.itemDetails")},
},
}},
Position: line(1),
},
}}},
{`ALTER TABLE products ADD COLUMN item STRING(MAX) AS (JSON_VALUE(itemDetails, '$.itemDetails')) STORED`, &DDL{Filename: "filename", List: []DDLStmt{
&AlterTable{
Name: "products",
Expand All @@ -1446,6 +1461,36 @@ func TestParseDDL(t *testing.T) {
Position: line(1),
},
}}},
{`ALTER TABLE products ADD COLUMN item ARRAY<STRING(MAX)> AS (JSON_QUERY_ARRAY(itemDetails, '$.itemDetails')) STORED`, &DDL{Filename: "filename", List: []DDLStmt{
&AlterTable{
Name: "products",
Alteration: AddColumn{Def: ColumnDef{
Name: "item",
Type: Type{Base: String, Array: true, Len: MaxLen},
Position: line(1),
Generated: Func{
Name: "JSON_QUERY_ARRAY",
Args: []Expr{ID("itemDetails"), StringLiteral("$.itemDetails")},
},
}},
Position: line(1),
},
}}},
{`ALTER TABLE products ADD COLUMN item ARRAY<STRING(MAX)> AS (JSON_VALUE_ARRAY(itemDetails, '$.itemDetails')) STORED`, &DDL{Filename: "filename", List: []DDLStmt{
&AlterTable{
Name: "products",
Alteration: AddColumn{Def: ColumnDef{
Name: "item",
Type: Type{Base: String, Array: true, Len: MaxLen},
Position: line(1),
Generated: Func{
Name: "JSON_VALUE_ARRAY",
Args: []Expr{ID("itemDetails"), StringLiteral("$.itemDetails")},
},
}},
Position: line(1),
},
}}},
{
`ALTER STATISTICS auto_20191128_14_47_22UTC SET OPTIONS (allow_gc=false)`,
&DDL{
Expand Down