Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf(storage): remove protobuf's copy of data on unmarshalling #9526

Merged
merged 13 commits into from
Mar 19, 2024
Merged

perf(storage): remove protobuf's copy of data on unmarshalling #9526

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
58f5314
draft(storage): read optimization proof of concept
BrennaEpp Feb 21, 2024
112bae1
go mod tidy, nits
BrennaEpp Feb 21, 2024
d592214
add custom decoding for the first msg
BrennaEpp Mar 8, 2024
7f11278
change marshalling, add fields to err msg, add crc32c parsing
BrennaEpp Mar 14, 2024
427ad59
clarify comment
BrennaEpp Mar 14, 2024
5ca2d2f
Merge branch 'main' into protobuf-1
BrennaEpp Mar 14, 2024
8ef71fb
update comment
BrennaEpp Mar 14, 2024
d1a9f00
add test + fix empty struct decoding
BrennaEpp Mar 15, 2024
85335d0
update headrer
BrennaEpp Mar 15, 2024
50f8286
Merge branch 'main' into protobuf-1
BrennaEpp Mar 15, 2024
5b2a0f0
Merge branch 'main' into protobuf-1
BrennaEpp Mar 18, 2024
07e6b4f
loop over bytes instead of reusing function
BrennaEpp Mar 19, 2024
b06366b
Merge branch 'main' into protobuf-1
BrennaEpp Mar 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
Prev Previous commit
Next Next commit
clarify comment
  • Loading branch information
@BrennaEpp
BrennaEpp committed Mar 14, 2024
commit 427ad59d1a37636ee65b30a75c4356adcd0ae25a
7 changes: 4 additions & 3 deletions storage/grpc_client.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1526,9 +1526,10 @@ func (r *gRPCReader) Close() error {
return nil
}

// recv attempts to Recv the next chunk of content on the stream. In the event
// that a retryable error is encountered, the stream will be closed, reopened,
// and Recv again. This will attempt to Recv until one of the following is true:
// recv attempts to Recv the next message on the stream and extract the object
// data that it contains. In the event that a retryable error is encountered,
// the stream will be closed, reopened, and RecvMsg again.
// This will attempt to Recv until one of the following is true:
//
// * Recv is successful
// * A non-retryable error is encountered
Expand Down