Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(spanner/spansql): support Table rename & Table synonym #9275

Merged
merged 12 commits into from
Mar 10, 2024
Merged

feat(spanner/spansql): support Table rename & Table synonym #9275

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
787200d
feat(spanner/spansql): support Table rename & Table synonym
killah777 Jan 18, 2024
5882e18
Update spanner/spansql/parser.go
killah777 Jan 19, 2024
56afa60
Merge branch 'main' into rename_table_dev1
killah777 Jan 19, 2024
26d4a1f
Merge branch 'main' into rename_table_dev1
killah777 Feb 22, 2024
adf8df0
Merge branch 'googleapis:main' into rename_table_dev1
killah777 Feb 26, 2024
7fcd109
Merge branch 'main' into rename_table_dev1
killah777 Mar 7, 2024
fcca278
Merge branch 'main' into rename_table_dev1
killah777 Mar 8, 2024
c6acf38
Merge branch 'main' into rename_table_dev1
killah777 Mar 8, 2024
a26bced
Merge branch 'googleapis:main' into rename_table_dev1
killah777 Mar 8, 2024
d8e82dc
Merge branch 'main' into rename_table_dev1
killah777 Mar 9, 2024
9bd7d76
go fmt
killah777 Mar 10, 2024
5705fff
don't use underscores in Go names
killah777 Mar 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
Prev Previous commit
don't use underscores in Go names
  • Loading branch information
@killah777
killah777 committed Mar 10, 2024
commit 5705fffdc2444d7ed6f0b31287d917f57252fb21
10 changes: 5 additions & 5 deletions spanner/spansql/parser.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1773,11 +1773,11 @@ func (p *parser) parseAlterTable() (*AlterTable, *parseError) {
}
case tok.caseEqual("RENAME"):
if p.eat("TO") {
new_name, err := p.parseTableOrIndexOrColumnName()
newName, err := p.parseTableOrIndexOrColumnName()
if err != nil {
return nil, err
}
rt := RenameTo{ToName: new_name}
rt := RenameTo{ToName: newName}
if p.eat(",", "ADD", "SYNONYM") {
synonym, err := p.parseTableOrIndexOrColumnName()
if err != nil {
Expand Down Expand Up @@ -1812,18 +1812,18 @@ func (p *parser) parseRenameTable() (*RenameTable, *parseError) {

var renameOps []TableRenameOp
for {
from_name, err := p.parseTableOrIndexOrColumnName()
fromName, err := p.parseTableOrIndexOrColumnName()
if err != nil {
return nil, err
}
if err := p.expect("TO"); err != nil {
return nil, err
}
to_name, err := p.parseTableOrIndexOrColumnName()
toName, err := p.parseTableOrIndexOrColumnName()
if err != nil {
return nil, err
}
renameOps = append(renameOps, TableRenameOp{FromName: from_name, ToName: to_name})
renameOps = append(renameOps, TableRenameOp{FromName: fromName, ToName: toName})

tok := p.next()
if tok.err != nil {
Expand Down