chore: add universe compatibility with older versions of api-core #2372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
24648f8
to
6d25555
Compare
56e3ea5
to
6791674
Compare
2e5baaf
to
7875e80
Compare
195610f
to
b73ecfd
Compare
e3c7566
to
7c91b9b
Compare
37658e9
to
4524943
Compare
3fcff41
to
2f5678c
Compare
parthea
approved these changes
Mar 28, 2024
| else: | ||
| if hasattr(google.api_core.client_options.ClientOptions, "universe_domain"): | ||
|
|
||
| def test_client_options_universe_with_older_version_of_api_core(self): |
There was a problem hiding this comment.
Should we also add a test case for http credentials. eg. test_http_credentials_client_options_universe_with_older_version_of_api_core?
There was a problem hiding this comment.
setting clientOptions.universe_domain will raise an exception before we even check for credentials in build_from_document. Therefore, testing different type of credentials while also passing in clientOptions.universe_domain might not add much value here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.