Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not use autoload when check class existence. #1991

Merged
merged 1 commit into from
Nov 11, 2020

Conversation

ilyaguy
Copy link
Contributor

@ilyaguy ilyaguy commented Nov 10, 2020

Do not use autoload functionality when check class existence.
With default "true" it will fail on custom autoload.

Do not use autoload functionality when check class existance.
With default "true" it will fail on custom autoload.
@ilyaguy ilyaguy requested a review from a team as a code owner November 10, 2020 11:19
@google-cla
Copy link

google-cla bot commented Nov 10, 2020

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added the cla: no This human has *not* signed the Contributor License Agreement. label Nov 10, 2020
@ilyaguy
Copy link
Contributor Author

ilyaguy commented Nov 10, 2020

@googlebot I signed it!

@google-cla google-cla bot added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Nov 10, 2020
@bshaffer bshaffer merged commit 7a92d4d into googleapis:master Nov 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants