gensupport: only retry storage media upload requests #538
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This modifies the changes in googleapis#528 by reverting the changes to SendRequest (which is widely used) and instead moving the new logic to a separate function, SendAndRetryRequest which will only be used on the initial request for media uploads. There is some code duplication from SendRequest now, which I can de-duplicate if folks think this is a good approach Fixes googleapis#2469
frankyn
approved these changes
Jun 17, 2020
|
CL title should probably say something like "only retry media upload requests"? The method name is an internal detail (gensupport is internal). But if someone were to look through commit history, this would explain a change in behavior between versions (in addition to release notes of course) |
|
er, PR title :) |
|
@broady good point, thanks. :) |
codyoss
reviewed
Jun 18, 2020
|
Discussed this with @codyoss offline-- we do think it makes sense to limit scope to storage for right now until the effects have been more fully evaluated. It ended up being a simple change in gen.go to accomplish this (I verified by running the generation locally and confirming that only the one call I was targeting in storage-gen.go is now impacted once generation runs). |
codyoss
approved these changes
Jun 18, 2020
This was referenced Jun 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This modifies the changes in #528 by reverting the changes
to SendRequest (which is widely used) and instead moving the
new logic to a separate function, SendAndRetryRequest which
will only be used on the initial request for media uploads.
There is some code duplication from SendRequest now, which I
can de-duplicate if folks think this is a good approach
Fixes googleapis/google-cloud-go#2469