Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: expose experimental universe-related options #2264

Merged
merged 8 commits into from
Nov 30, 2023
Merged

feat: expose experimental universe-related options #2264

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
e9212d8
feat: carve out experimental universe option
shollyman Nov 10, 2023
a49f296
add default option as well
shollyman Nov 16, 2023
bca5916
Merge branch 'main' into universe-option
shollyman Nov 17, 2023
3a8dca7
fix default universe
shollyman Nov 17, 2023
ef1513e
Merge branch 'main' into universe-option
shollyman Nov 30, 2023
66320c3
move default option internal
shollyman Nov 30, 2023
bc27a0e
redact default from public
shollyman Nov 30, 2023
76466e7
address reviewer comment feedback
shollyman Nov 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
Prev Previous commit
Next Next commit
redact default from public
  • Loading branch information
@shollyman
shollyman committed Nov 30, 2023
commit bc27a0e6cc24f1732b289cc858116f0d5397773f
13 changes: 0 additions & 13 deletions option/option.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -356,16 +356,3 @@ type withUniverseDomain string
func (w withUniverseDomain) Apply(o *internal.DialSettings) {
o.UniverseDomain = string(w)
}

// WithDefaultUniverseDomain returns a ClientOption that sets the universe domain.
//
// This is an EXPERIMENTAL API and may be changed or removed in the future.
func WithDefaultUniverseDomain(ud string) ClientOption {
return withDefaultUniverseDomain(ud)
}

type withDefaultUniverseDomain string

func (w withDefaultUniverseDomain) Apply(o *internal.DialSettings) {
o.DefaultUniverseDomain = string(w)
}