Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: remove forced dependency on main google-cloud-go module #2559

Open
noahdietz opened this issue Apr 30, 2024 · 2 comments
Open

deps: remove forced dependency on main google-cloud-go module #2559

noahdietz opened this issue Apr 30, 2024 · 2 comments
Assignees
@codyoss
Labels
type: cleanup An internal cleanup or hygiene concern.

Comments

@noahdietz
Copy link
Contributor

We need to force a dependency on the cloud.google.com/go main module to ensure that the module is resolved unambiguously. The issue encountered in #2543 and present in #2552 (see below) is odd though because we have other dependencies with newer, unambiguous dependencies on this module. These should win out during dep resolution, but they aren't for some reason.

Forcing a direct dep on the module resolves the ambiguity but is not an ideal solution.

/root/go/pkg/mod/cloud.google.com/go/[email protected]/internal/internal.go:31:2: ambiguous import: found package cloud.google.com/go/compute/metadata in multiple modules:
	cloud.google.com/go v0.26.0 (/root/go/pkg/mod/cloud.google.com/[email protected]/compute/metadata)
	cloud.google.com/go/compute/metadata v0.3.0 (/root/go/pkg/mod/cloud.google.com/go/compute/[email protected]) (compile)
@noahdietz noahdietz added the type: cleanup An internal cleanup or hygiene concern. label Apr 30, 2024
@noahdietz noahdietz mentioned this issue Apr 30, 2024
Merged
@quartzmo
Copy link
Member

we have other dependencies with newer, unambiguous dependencies on this module

Can you explicitly document what these are?

@noahdietz
Copy link
Contributor Author

we have other dependencies with newer, unambiguous dependencies on this module

Can you explicitly document what these are?

At HEAD before forcing the dep:

$ go mod graph | grep ' cloud.google.com/go@'

cloud.google.com/go/[email protected] cloud.google.com/[email protected]
cloud.google.com/go/[email protected] cloud.google.com/[email protected]
google.golang.org/[email protected] cloud.google.com/[email protected]
google.golang.org/[email protected] cloud.google.com/[email protected]
cloud.google.com/go/[email protected] cloud.google.com/[email protected]
cloud.google.com/go/[email protected] cloud.google.com/[email protected]
cloud.google.com/go/[email protected] cloud.google.com/[email protected]
cloud.google.com/go/[email protected] cloud.google.com/[email protected]
cloud.google.com/go/[email protected] cloud.google.com/[email protected]
cloud.google.com/go/[email protected] cloud.google.com/[email protected]
cloud.google.com/go/[email protected] cloud.google.com/[email protected]
cloud.google.com/go/[email protected] cloud.google.com/[email protected]
cloud.google.com/go/[email protected] cloud.google.com/[email protected]
cloud.google.com/go/[email protected] cloud.google.com/[email protected]
cloud.google.com/go/[email protected] cloud.google.com/[email protected]
cloud.google.com/go/[email protected] cloud.google.com/[email protected]
cloud.google.com/go/[email protected] cloud.google.com/[email protected]
cloud.google.com/go/[email protected] cloud.google.com/[email protected]
cloud.google.com/go/[email protected] cloud.google.com/[email protected]
cloud.google.com/go/[email protected] cloud.google.com/[email protected]
cloud.google.com/go/[email protected] cloud.google.com/[email protected]
cloud.google.com/go/[email protected] cloud.google.com/[email protected]
cloud.google.com/go/[email protected] cloud.google.com/[email protected]
cloud.google.com/go/[email protected] cloud.google.com/[email protected]
cloud.google.com/go/[email protected] cloud.google.com/[email protected]
cloud.google.com/go/[email protected] cloud.google.com/[email protected]
cloud.google.com/go/[email protected] cloud.google.com/[email protected]
cloud.google.com/go/[email protected] cloud.google.com/[email protected]
cloud.google.com/go/dataproc/[email protected] cloud.google.com/[email protected]
cloud.google.com/go/[email protected] cloud.google.com/[email protected]
cloud.google.com/go/[email protected] cloud.google.com/[email protected]
cloud.google.com/go/[email protected] cloud.google.com/[email protected]
cloud.google.com/go/[email protected] cloud.google.com/[email protected]
cloud.google.com/go/[email protected] cloud.google.com/[email protected]
cloud.google.com/go/[email protected] cloud.google.com/[email protected]
cloud.google.com/go/[email protected] cloud.google.com/[email protected]
cloud.google.com/go/[email protected] cloud.google.com/[email protected]
cloud.google.com/go/[email protected] cloud.google.com/[email protected]
cloud.google.com/go/[email protected] cloud.google.com/[email protected]
cloud.google.com/go/[email protected] cloud.google.com/[email protected]
cloud.google.com/go/[email protected] cloud.google.com/[email protected]
cloud.google.com/go/[email protected] cloud.google.com/[email protected]
cloud.google.com/go/[email protected] cloud.google.com/[email protected]
cloud.google.com/go/[email protected] cloud.google.com/[email protected]
cloud.google.com/go/[email protected] cloud.google.com/[email protected]
cloud.google.com/go/[email protected] cloud.google.com/[email protected]
cloud.google.com/go/[email protected] cloud.google.com/[email protected]
cloud.google.com/go/[email protected] cloud.google.com/[email protected]
cloud.google.com/go/[email protected] cloud.google.com/[email protected]
cloud.google.com/go/[email protected] cloud.google.com/[email protected]
cloud.google.com/go/[email protected] cloud.google.com/[email protected]
cloud.google.com/go/[email protected] cloud.google.com/[email protected]
cloud.google.com/go/[email protected] cloud.google.com/[email protected]
cloud.google.com/go/[email protected] cloud.google.com/[email protected]
cloud.google.com/go/[email protected] cloud.google.com/[email protected]
cloud.google.com/go/[email protected] cloud.google.com/[email protected]
cloud.google.com/go/[email protected] cloud.google.com/[email protected]
cloud.google.com/go/[email protected] cloud.google.com/[email protected]
cloud.google.com/go/[email protected] cloud.google.com/[email protected]
cloud.google.com/go/[email protected] cloud.google.com/[email protected]
cloud.google.com/go/[email protected] cloud.google.com/[email protected]
cloud.google.com/go/[email protected] cloud.google.com/[email protected]
cloud.google.com/go/[email protected] cloud.google.com/[email protected]
cloud.google.com/go/[email protected] cloud.google.com/[email protected]
cloud.google.com/go/[email protected] cloud.google.com/[email protected]
cloud.google.com/go/[email protected] cloud.google.com/[email protected]
cloud.google.com/go/[email protected] cloud.google.com/[email protected]
cloud.google.com/go/[email protected] cloud.google.com/[email protected]
cloud.google.com/go/[email protected] cloud.google.com/[email protected]
cloud.google.com/go/[email protected] cloud.google.com/[email protected]
cloud.google.com/go/[email protected] cloud.google.com/[email protected]
cloud.google.com/go/[email protected] cloud.google.com/[email protected]
cloud.google.com/go/[email protected] cloud.google.com/[email protected]
cloud.google.com/go/[email protected] cloud.google.com/[email protected]
cloud.google.com/go/[email protected] cloud.google.com/[email protected]
cloud.google.com/go/[email protected] cloud.google.com/[email protected]
cloud.google.com/go/[email protected] cloud.google.com/[email protected]
cloud.google.com/go/[email protected] cloud.google.com/[email protected]
cloud.google.com/go/[email protected] cloud.google.com/[email protected]
cloud.google.com/go/vision/[email protected] cloud.google.com/[email protected]
cloud.google.com/go/[email protected] cloud.google.com/[email protected]
cloud.google.com/go/[email protected] cloud.google.com/[email protected]
cloud.google.com/go/[email protected] cloud.google.com/[email protected]
cloud.google.com/go/[email protected] cloud.google.com/[email protected]
cloud.google.com/go/[email protected] cloud.google.com/[email protected]
google.golang.org/[email protected] cloud.google.com/[email protected]
google.golang.org/[email protected] cloud.google.com/[email protected]

gcf-merge-on-green bot pushed a commit that referenced this issue Apr 30, 2024
@noahdietz
fix: temp patch cloud.google.com/go ambiguity (#2560)
3eb92f1 
Force dependency on `cloud.google.com/go` main module to resolve ambiguity.

Fixes #2543
Updates #2559
@release-please release-please bot mentioned this issue Apr 30, 2024
Merged
gcf-merge-on-green bot pushed a commit that referenced this issue Apr 30, 2024
@release-please
chore(main): release 0.177.0 (#2545)
a11ef60 
🤖 I have created a release *beep* *boop*
---


## [0.177.0](https://togithub.com/googleapis/google-api-go-client/compare/v0.176.1...v0.177.0) (2024-04-30)


### Features

* **all:** Auto-regenerate discovery clients ([#2548](https://togithub.com/googleapis/google-api-go-client/issues/2548)) ([32a5d10](https://togithub.com/googleapis/google-api-go-client/commit/32a5d10b1870bacb93fdf065e5ce7923c04039e8))
* **all:** Auto-regenerate discovery clients ([#2550](https://togithub.com/googleapis/google-api-go-client/issues/2550)) ([f9bf96d](https://togithub.com/googleapis/google-api-go-client/commit/f9bf96df3a9a7ee9eb5b4b01c60d50f4c70e45c9))
* **all:** Auto-regenerate discovery clients ([#2551](https://togithub.com/googleapis/google-api-go-client/issues/2551)) ([4418f5f](https://togithub.com/googleapis/google-api-go-client/commit/4418f5fc551ce9a1edda277ddf483f3dd596d9aa))
* **all:** Auto-regenerate discovery clients ([#2553](https://togithub.com/googleapis/google-api-go-client/issues/2553)) ([2f46e14](https://togithub.com/googleapis/google-api-go-client/commit/2f46e14ff3836ec2ed0e9b08c33b3ec3d29e707b))
* **all:** Auto-regenerate discovery clients ([#2556](https://togithub.com/googleapis/google-api-go-client/issues/2556)) ([fb153c0](https://togithub.com/googleapis/google-api-go-client/commit/fb153c030eb62f149abff30e6948ea1933a9034c))
* Reduce code size by 29% ([#2544](https://togithub.com/googleapis/google-api-go-client/issues/2544)) ([2f2505b](https://togithub.com/googleapis/google-api-go-client/commit/2f2505b83d909fafc4dcf24aff9bb6eb3b7333d7))


### Bug Fixes

* Split large compute file up ([#2546](https://togithub.com/googleapis/google-api-go-client/issues/2546)) ([1b6db6c](https://togithub.com/googleapis/google-api-go-client/commit/1b6db6c4446668599f8db8edda2dde85d7b6015d))
* Temp patch cloud.google.com/go ambiguity ([#2560](https://togithub.com/googleapis/google-api-go-client/issues/2560)) ([3eb92f1](https://togithub.com/googleapis/google-api-go-client/commit/3eb92f1acf25ec8ac4eeb0fa75dbb04a10db36e0)), refs [#2543](https://togithub.com/googleapis/google-api-go-client/issues/2543) [#2559](https://togithub.com/googleapis/google-api-go-client/issues/2559)

---
This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
codyoss added a commit to codyoss/google-api-go-client that referenced this issue May 31, 2024
@codyoss
fix: add another temporary dep on genproto
c74cbfb 
I believe the soure for these issue is opencensus outdated imports
of really old version of our libraries, genproto. Once we drop that
dep we should test removing these workarounds.

Updates: googleapis#2559
Fixes: googleapis#2613
@codyoss codyoss mentioned this issue May 31, 2024
Merged
gcf-merge-on-green bot pushed a commit that referenced this issue May 31, 2024
@codyoss
fix: add another temporary dep on genproto (#2614)
4f98211 
I believe the soure for these issue is opencensus outdated imports of really old version of our libraries, genproto. Once we drop that dep we should test removing these workarounds.

Updates: #2559
Fixes: #2613
@release-please release-please bot mentioned this issue May 31, 2024
Merged
gcf-merge-on-green bot pushed a commit that referenced this issue Jun 4, 2024
@release-please
chore(main): release 0.183.0 (#2615)
c642c84 
🤖 I have created a release *beep* *boop*
---


## [0.183.0](https://togithub.com/googleapis/google-api-go-client/compare/v0.182.0...v0.183.0) (2024-06-04)


### Features

* **all:** Auto-regenerate discovery clients ([#2611](https://togithub.com/googleapis/google-api-go-client/issues/2611)) ([1de148b](https://togithub.com/googleapis/google-api-go-client/commit/1de148b049cad72efb924df7f3435bcbca7d214f))
* **all:** Auto-regenerate discovery clients ([#2616](https://togithub.com/googleapis/google-api-go-client/issues/2616)) ([5f21214](https://togithub.com/googleapis/google-api-go-client/commit/5f21214e2284f5162d89383f528326325091796c))
* **all:** Auto-regenerate discovery clients ([#2617](https://togithub.com/googleapis/google-api-go-client/issues/2617)) ([08fdd71](https://togithub.com/googleapis/google-api-go-client/commit/08fdd71cae0bbfd16ed7e13a00c8bc7dd596ce94))
* **all:** Auto-regenerate discovery clients ([#2619](https://togithub.com/googleapis/google-api-go-client/issues/2619)) ([c7f1614](https://togithub.com/googleapis/google-api-go-client/commit/c7f161413cf50b50db98ba483afc2f2344e0896f))
* **all:** Auto-regenerate discovery clients ([#2622](https://togithub.com/googleapis/google-api-go-client/issues/2622)) ([0077748](https://togithub.com/googleapis/google-api-go-client/commit/007774894a48d24634ace7b9e09def4d61433f7f))


### Bug Fixes

* Add another temporary dep on genproto ([#2614](https://togithub.com/googleapis/google-api-go-client/issues/2614)) ([4f98211](https://togithub.com/googleapis/google-api-go-client/commit/4f9821115b5b14b2a32a4cdcbbb84bed018dac2c)), refs [#2559](https://togithub.com/googleapis/google-api-go-client/issues/2559) [#2613](https://togithub.com/googleapis/google-api-go-client/issues/2613)

---
This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@codyoss codyoss

Labels
type: cleanup An internal cleanup or hygiene concern.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@quartzmo @codyoss @noahdietz