fix: fix TypeError: MessageToJson() got an unexpected keyword argument 'including_default_value_fields' #1936
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t 'including_default_value_fields'
457241b
to
baf01d4
Compare
|
Filed googleapis/proto-plus-python#431 to address the remaining issue in proto-plus |
|
Is the behavior without this parameter the same as before (which defaulted to EDIT: Nm, I see your comments in #1935, and it looks like the default for the renamed parameter behaves the same as the code before this PR. |
vchudnov-g
approved these changes
Feb 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1935 🦕