Skip to content

Make the goldens-prerelease presubmit check optional #1945

Closed
@parthea

Description

@parthea

A goldens-prerelease presubmit check was recently added in #1931. We should make the goldens-prerelease presubmit check optional. The purpose of the check is to run tests against pre-release versions of dependencies. As a breaking change was released last week in a protobuf pre-release, the check is currently failing. As this check runs against pre-release versions of dependencies, we should expect more failures moving forward. For the specific failure in #1935, it will take some time to add support for protobuf 5.x (See the work in progress PR #1936 which is blocked on googleapis/proto-plus-python#425 and googleapis/proto-plus-python#431).

We don't want to block development on this issue since we currently have a constraint to restrict new major versions of protobuf in generated clients. For example, see

"protobuf>=3.19.5,<5.0.0dev,!=3.20.0,!=3.20.1,!=4.21.0,!=4.21.1,!=4.21.2,!=4.21.3,!=4.21.4,!=4.21.5",

Solving the issue of the failing presubmit is being prioritized as P1 but it should not block other P1 work.

Metadata

Metadata

Assignees

No one assigned

    Labels

    priority: p1Important issue which blocks shipping the next release. Will be fixed prior to next release.type: processA process-related concern. May include testing, release, or the like.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions