goldens-prerelease test fails with TypeError: MessageToJson() got an unexpected keyword argument 'including_default_value_fields'
#1935
Labels
priority: p2
Moderately-important priority. Fix may not be included in next release.
type: bug
Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
The pre-release test failed in PR #1932 around the time of a protobuf pre-release
protobuf==5.26.0rc2
. https://pypi.org/project/protobuf/5.26.0rc2/The test is failing because the
including_default_value_fields
argument was renamed inMessageToJson
.The default value of
including_default_value_fields
isFalse
, which is the same value that is being set, so we can remove it from the call to resolve the issue.version 3.19.6 - default value of
including_default_value_fields
isFalse
https://github.com/protocolbuffers/protobuf/blob/5cba162a5d93f8df786d828621019e03e50edb4f/python/google/protobuf/json_format.py#L92
At the time that the argument was removed - default value of
including_default_value_fields
isFalse
protocolbuffers/protobuf@2699579#diff-8de817c14d6a087981503c9aea38730b1b3e98f4e306db5ff9d525c7c304f234
The text was updated successfully, but these errors were encountered: