Merge pull request #152 from 96andrei/AndroidCustomData

Fixed Custom Dimensions and Custom Metrics on Android.
googleanalytics · Apr 4, 2017 · ad7bf51 · ad7bf51
2 parents cc437f4 + ab171cb
commit ad7bf51
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 4 deletions.
diff --git a/source/Plugins/GoogleAnalyticsV4/GoogleAnalyticsAndroidV4.cs b/source/Plugins/GoogleAnalyticsV4/GoogleAnalyticsAndroidV4.cs
@@ -100,6 +100,17 @@ public class GoogleAnalyticsAndroidV4 : IDisposable {
  eventBuilder.Call<AndroidJavaObject>("setAction", new object[] { builder.GetEventAction() });
  eventBuilder.Call<AndroidJavaObject>("setLabel", new object[] { builder.GetEventLabel() });
  eventBuilder.Call<AndroidJavaObject>("setValue", new object[] { builder.GetEventValue() });
+
+ foreach(KeyValuePair<int, string> i in builder.GetCustomDimensions())
+ {
+ eventBuilder.Call<AndroidJavaObject>("setCustomDimension", new object[] { i.Key, i.Value });
+ }
+
+ foreach(KeyValuePair<int, float> i in builder.GetCustomMetrics())
+ {
+ eventBuilder.Call<AndroidJavaObject>("setCustomMetric", new object[] { i.Key, i.Value });
+ }
+
  object[] builtEvent = new object[] { eventBuilder.Call<AndroidJavaObject>("build") };
  tracker.Call("send", builtEvent);
  }

diff --git a/source/Plugins/GoogleAnalyticsV4/GoogleAnalyticsMPV3.cs b/source/Plugins/GoogleAnalyticsV4/GoogleAnalyticsMPV3.cs
@@ -225,7 +225,7 @@ public IEnumerator HandleWWW(WWW request)
  WWW.EscapeURL(entry.Value.ToString());
  }
  }
- foreach(KeyValuePair<int, string> entry in builder.GetCustomMetrics())
+ foreach(KeyValuePair<int, float> entry in builder.GetCustomMetrics())
  {
  if (entry.Value != null) {
  url += Fields.CUSTOM_METRIC.ToString() + entry.Key + "=" +

diff --git a/source/Plugins/GoogleAnalyticsV4/HitBuilders/HitBuilder.cs b/source/Plugins/GoogleAnalyticsV4/HitBuilders/HitBuilder.cs
@@ -28,7 +28,7 @@ public abstract class HitBuilder<T> {
 
  private Dictionary<int, string> customDimensions =
  new Dictionary<int,string>();
- private Dictionary<int, string> customMetrics = new Dictionary<int,string>();
+ private Dictionary<int, float> customMetrics = new Dictionary<int,float>();
 
  private string campaignName = "";
  private string campaignSource = "";
@@ -51,12 +51,12 @@ public abstract class HitBuilder<T> {
  return customDimensions;
  }
 
- public T SetCustomMetric(int metricNumber, string value) {
+ public T SetCustomMetric(int metricNumber, float value) {
  customMetrics.Add(metricNumber, value);
  return GetThis();
  }
 
- public Dictionary<int, string> GetCustomMetrics() {
+ public Dictionary<int, float> GetCustomMetrics() {
  return customMetrics;
  }