Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Account for double-encoded Query Explorer links in the wild. #48

Merged
merged 2 commits into from
Apr 1, 2015
Merged

Account for double-encoded Query Explorer links in the wild. #48

merged 2 commits into from
Apr 1, 2015

Conversation

philipwalton
Copy link
Member

No description provided.

@philipwalton
Copy link
Member Author

Updated to only double-decode when the string "%253A" (a colon, double-encoded) is found.

@grano
Copy link
Contributor

grano commented Apr 1, 2015

LGTM

philipwalton added a commit that referenced this pull request Apr 1, 2015
@philipwalton
Merge pull request #48 from philipwalton/decode-query-params
0baf014 
Account for double-encoded Query Explorer links in the wild.
@philipwalton philipwalton merged commit 0baf014 into googleanalytics:master Apr 1, 2015
@philipwalton philipwalton deleted the decode-query-params branch April 1, 2015 00:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@philipwalton @grano