Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RESOLVE ISSUES PLEASE #1235

Open
wants to merge 7 commits into
base: dependabot/npm_and_yarn/devcert-1.2.2
Choose a base branch
from
Open

Conversation

Gordon-x
Copy link

@Gordon-x Gordon-x commented Feb 9, 2023

?

@google-cla
Copy link

google-cla bot commented Feb 9, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@Gordon-x Gordon-x changed the title Remove iOS Campaign URL Builder for GA4 (#937) RESOLVE ISSUES PLEASE Feb 9, 2023
ikuleshov and others added 6 commits February 10, 2023 09:28
* Add Schemas and validation class; begin tests

* Finish event schema spec

* Update state with validationMessages with messages from json validator

* ValidationMessages added to event builder frontend

* Add custom checks on payload attributes

* Remove duplicate error messages

* Only validate firebase payloads; aadd tests to schema validations

* cleanup

* Require login for event builder page

* Fix formatting warning

* Ensure userProperties exists before adding error

* Add specs, fix issues, begin formatting errors

* Add documentation to each error

* Add focus button to most errors

* Fix small bugs, fix failing specs

* Add additional check for params and items of events

* Respond to code review

* Fix failing spec; fix focus button on schema returned errors

* Removing params and items list checks -- not sure if they will prevent payload submission

* Don't validate empty items for events that don't require items

* fix warnings 1

* fix warnings 2
* Add payload textbox to Event Builder

* Create payload textbox, begin payload formatting logic

* Added format Payload button; able to format payload

* Add format Payload ability before validate event

* Payload is now being validated, bug still bugs

* Able to validate payload from textbox on first entry

* Add payload formatting errors

* Fix formatting issues

* Remove console logs

* Cleanup

* Fix typescript errors

* Improve design, fix linter errors

* Only validate payload for textbox entries

* Validate api_secret exists

* Fix linter errors

* Update naming

* Change payload URL

* Update styling
* Remove textbox when gtag.js is checkeked

* Validate for firebaseAppId OR measurementID

* Fix schema validation for app_instance_id vs client_id

* Try to remove weirdly formatted error messaging

* Item json schema validations for items array
* Upgrade all dependencies to the latest version and migrate to MUI5.

* address check-types issues
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants