Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes getMergeResourcesProvider query name so plugin doesn't use deprecated APIs. #82

Merged
merged 2 commits into from
Sep 5, 2019
Merged

Fixes getMergeResourcesProvider query name so plugin doesn't use deprecated APIs. #82

merged 2 commits into from
Sep 5, 2019

Conversation

rharter
Copy link
Contributor

@rharter rharter commented Sep 4, 2019 •
edited

I debugged the plugin to find that variant.respondsTo("mergeResourcesProvider") returns an empty collection, presumably because the actual method is called getMergeResourcesProvider, thought Groovy allows you to drop the get.

Fixes #65

@davidmotson davidmotson merged commit d3fb67f into google:master Sep 5, 2019
@mikehardy
Copy link

Cool!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidmotson davidmotson davidmotson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error using com.google.gms: google-services: 4.3.0 (and 4.3.1)
3 participants
@rharter @mikehardy @davidmotson