Use run_id instead of sha for docker tag #688
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gobbleturk
approved these changes
Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There have been collisions between the scheduled UnitTests execution and those triggered by merge to main.
This change replaces the github SHA with the run_id to ensure a distinct image tag across executions.
Example scheduled execution failure: https://github.com/google/maxtext/actions/runs/9387491342/job/25850532082
Due to a concurrent execution from merge: https://github.com/google/maxtext/actions/runs/9387152549/job/25849389719
Context on run_id from https://docs.github.com/en/actions/learn-github-actions/contexts#github-context: