Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix IntelLLVM compiler error #1644

Merged
merged 5 commits into from
Aug 10, 2023
Merged

Fix IntelLLVM compiler error #1644

merged 5 commits into from
Aug 10, 2023

Conversation

joannapng
Copy link
Contributor

In response to issue #1505

The IntelLLVM Compiler has the -ffast-math flag enabled by default, which in turn, turns on the -ffinite-math-only flag, which assumes that arguments and results are not NaNs or Infs. Use the -fno-finite-math-only flag to suppress the errors.

@google-cla
Copy link

google-cla bot commented Aug 10, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@dmah42
Copy link
Member

dmah42 commented Aug 10, 2023

failing windows release test is unrelated.

@dmah42
Copy link
Member

dmah42 commented Aug 10, 2023

we should consider adding intel compilers to the CI bots i think.

@dmah42
Copy link
Member

dmah42 commented Aug 10, 2023

thanks!

@dmah42 dmah42 merged commit 14961f1 into google:main Aug 10, 2023
58 of 60 checks passed
@joannapng joannapng deleted the intel-llvm-support branch August 10, 2023 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants