Enables a configurable SocketFactory for the RTSP client #9606
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
October 25, 2021 16:11
|
@ojw28 do you have a minute to review? Very keen on getting it into the next version. |
|
@claincly do you have any comment? |
claincly
reviewed
Nov 2, 2021
library/rtsp/src/main/java/com/google/android/exoplayer2/source/rtsp/RtspClient.java
Outdated
Show resolved
Hide resolved
claincly
requested changes
Nov 2, 2021
There was a problem hiding this comment.
Could you also add a section in
https://github.com/google/ExoPlayer/blob/95e6db931a047775c1aa792c452be7996167a08f/docs/rtsp.md
To provide more detail on the usage?
library/rtsp/src/main/java/com/google/android/exoplayer2/source/rtsp/RtspMediaPeriod.java
Outdated
Show resolved
Hide resolved
library/rtsp/src/main/java/com/google/android/exoplayer2/source/rtsp/RtspMediaSource.java
Outdated
Show resolved
Hide resolved
library/rtsp/src/main/java/com/google/android/exoplayer2/source/rtsp/RtspMediaSource.java
Outdated
Show resolved
Hide resolved
library/rtsp/src/main/java/com/google/android/exoplayer2/source/rtsp/RtspMediaSource.java
Outdated
Show resolved
Hide resolved
library/rtsp/src/main/java/com/google/android/exoplayer2/source/rtsp/RtspClient.java
Show resolved
Hide resolved
library/rtsp/src/main/java/com/google/android/exoplayer2/source/rtsp/RtspClient.java
Outdated
Show resolved
Hide resolved
library/rtsp/src/test/java/com/google/android/exoplayer2/source/rtsp/RtspClientTest.java
Outdated
Show resolved
Hide resolved
added 2 commits
November 2, 2021 14:58
|
@claincly the PR has been updated to the latest dev-v2 branch. Would you have time to re-review? |
|
@claincly Do you have any further comments to address? |
claincly
requested changes
Nov 10, 2021
library/rtsp/src/main/java/com/google/android/exoplayer2/source/rtsp/RtspMediaPeriod.java
Show resolved
Hide resolved
library/rtsp/src/test/java/com/google/android/exoplayer2/source/rtsp/RtspClientTest.java
Outdated
Show resolved
Hide resolved
|
@claincly latest feedback addressed. |
|
Looks good now, I'll start the merging process on our side. |
Should I rebase again? |
|
@claincly maybe more luck this week? ;-) |
|
Hello Sebastian,
I'll keep an eye on this, hopefully get it in this week, thanks for your
patience!
…On Mon, Nov 29, 2021 at 2:57 PM Sebastian Roth ***@***.***> wrote:
@claincly <https://github.com/claincly> maybe more luck this week? ;-)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#9606 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AUCMUUXJJXGNPXOKU6WVJP3UOOIELANCNFSM5GVEMXWA>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our use case is to route RTSP traffic coming from a IoT device through a specific network interface.
In order to achieve that, we setup a custom socket factory (which in turn just forwards to the actual interface).
This MR makes the socket factory configurable via the
RtspMediaPeriodclass etc.The MR contains a few basic tests - feedback welcome.