Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use appropriate decimal separator in playback speeds #9811

Closed
moneytoo opened this issue Dec 25, 2021 · 2 comments
Closed

Use appropriate decimal separator in playback speeds #9811

moneytoo opened this issue Dec 25, 2021 · 2 comments
Assignees
@ojw28
Labels
bug

Comments

@moneytoo
Copy link
Contributor

moneytoo commented Dec 25, 2021 •
edited

The exo_playback_speeds array contains values with hardcoded decimal separator (.).

When I have my device set to Czech language (and therefore to Czech locale), I would expect to see values like 1,5x (instead of 1.5x).

While it's probably clear to users from the context, in Czech locale 1.5x would meant 1500 times.

Other apps like YouTube and Files by Google use the localized values.

EDIT: YouTube also uses actual multiplication sign × instead of the latin letter x.
@ojw28 ojw28 self-assigned this Jan 4, 2022
@ojw28
Copy link
Contributor

ojw28 commented Jan 4, 2022

We should make sure these strings are translated. Thanks for reporting!

@ojw28
Copy link
Contributor

ojw28 commented Jan 4, 2022

We will fix this across a few of commits:

  1. Add translatable strings
  2. Add translations for the strings
  3. Update the UI components to use the translatable strings

tonihei pushed a commit to androidx/media that referenced this issue Jan 5, 2022
@ojw28 @tonihei
Add translatable playback speed strings
f7e88d7 
The UI component will be switched over to use them in a
subsequent commit, once the translations have been
imported.

Issue: google/ExoPlayer#9811
PiperOrigin-RevId: 419632617
tonihei pushed a commit that referenced this issue Jan 5, 2022
@ojw28 @tonihei
Add translatable playback speed strings
ac6207c 
The UI component will be switched over to use them in a
subsequent commit, once the translations have been
imported.

Issue: #9811
PiperOrigin-RevId: 419632617
icbaker pushed a commit to androidx/media that referenced this issue Jan 26, 2022
@ojw28 @icbaker
Update translations
8f65b7f 
Issue: google/ExoPlayer#9811
PiperOrigin-RevId: 423849421
icbaker pushed a commit to androidx/media that referenced this issue Jan 26, 2022
@ojw28 @icbaker
Use translatable playback speed strings
b1d8a97 
Issue: google/ExoPlayer#9811
PiperOrigin-RevId: 423855051
icbaker pushed a commit that referenced this issue Jan 26, 2022
@ojw28 @icbaker
Update translations
34102ee 
Issue: #9811
PiperOrigin-RevId: 423849421
icbaker pushed a commit that referenced this issue Jan 26, 2022
@ojw28 @icbaker
Use translatable playback speed strings
abef4f4 
Issue: #9811
PiperOrigin-RevId: 423855051
@ojw28 ojw28 closed this as completed Feb 7, 2022
@google google locked and limited conversation to collaborators Apr 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ojw28 ojw28

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@moneytoo @ojw28