Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tolerance for rtsp track timing #9775

Closed
ghotik opened this issue Dec 10, 2021 · 3 comments
Closed

tolerance for rtsp track timing #9775

ghotik opened this issue Dec 10, 2021 · 3 comments
Assignees
@claincly
Labels
enhancement

Comments

@ghotik
Copy link

ghotik commented Dec 10, 2021

[REQUIRED] Use case description

In my app, when developing disconnected from the cameras vpn, I find it handy to steal some frames from public rtsp streams, and this one is my favourite one:

rtsp://31.0.225.93/cam/realmonitor?channel=3&subtype=00&authbasic=YWRtaW46MTIzOTg3

but EXOPlayer doesn't show frames from this public camera because of the following error:

Server did not provide timing for track ...

Proposed solution

I understand that the protocol from that camera may be not fully compliant to rtsp standards, but I found that commenting lines 516-519 in RtspMediaPeriod.java make the camera perfectly visible.

Alternatives considered

Add an EXOPlayer settings option to make the control optional
@claincly
Copy link
Contributor

We have received a few similar issues now. Will include an option to ignore the timing info.

@ghotik
Copy link
Author

ghotik commented Dec 13, 2021

Thanks a lot!

@ghotik ghotik closed this as completed Dec 13, 2021
@ojw28 ojw28 reopened this Dec 21, 2021
@NicolasGodfather
Copy link

The same. I am waiting this update too. How soon you plan to fix it in new release?

@claincly claincly mentioned this issue Jan 20, 2022
Closed
icbaker pushed a commit to androidx/media that referenced this issue Jan 26, 2022
@claincly @icbaker
Handle when RTSP track timing is not available.
914cf42 
Issue: google/ExoPlayer#9775

We got a few issues for this on GH already. Some RTSP servers do not provide
track timing in PLAY responses, or the timings are invalid.

Missing timing means the RTSP stream is not seekable. Added method to
1. Update the timeline that seek is not possible
2. Report read discontinuity so that playback can start from the beginning.

PiperOrigin-RevId: 423281439
icbaker pushed a commit that referenced this issue Jan 26, 2022
@claincly @icbaker
Handle when RTSP track timing is not available.
5a60db3 
Issue: #9775

We got a few issues for this on GH already. Some RTSP servers do not provide
track timing in PLAY responses, or the timings are invalid.

Missing timing means the RTSP stream is not seekable. Added method to
1. Update the timeline that seek is not possible
2. Report read discontinuity so that playback can start from the beginning.

PiperOrigin-RevId: 423281439
@claincly claincly closed this as completed Feb 6, 2022
@google google locked and limited conversation to collaborators Apr 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@claincly claincly

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@ojw28 @NicolasGodfather @ghotik @claincly