Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Numbers in rew / fwd button not visible in dark mode #9765

Closed
tobiasKaminsky opened this issue Dec 7, 2021 · 3 comments
Closed

Numbers in rew / fwd button not visible in dark mode #9765

tobiasKaminsky opened this issue Dec 7, 2021 · 3 comments
Assignees
@ojw28
Labels
bug

Comments

@tobiasKaminsky
Copy link

On Exoplayer 2.16.1:

Light mode:
image

Dark mode:
image

It seems that the numbers are adapted to black/white depending on light/dark mode.

(ref:

ExoPlayer/library/ui/src/main/res/values/styles.xml

Line 97 in 3509f50

<item name="backgroundTint">@android:color/white</item>
)
@ojw28
Copy link
Contributor

ojw28 commented Dec 7, 2021

Could you provide complete steps explaining how to reproduce this? E.g., what device are you using, how are you enabling night mode, and anything else relevant.

@ojw28
Copy link
Contributor

ojw28 commented Dec 7, 2021

I can reproduce this when using:

<style name="AppTheme" parent="Theme.MaterialComponents.DayNight">

It doesn't reproduce when using:

<style name="AppTheme" parent="Theme.AppCompat.DayNight">

Nevertheless, please confirm your exact use case.

@tobiasKaminsky
Copy link
Author

This is happening in https://github.com/nextcloud/android
and we use
https://github.com/nextcloud/android/blob/bcafbbbd5ba7606dcd658f573500921b504aca76/src/main/res/values/styles.xml#L23

icbaker pushed a commit to androidx/media that referenced this issue Dec 10, 2021
@ojw28 @icbaker
Fix FFWD/RWND color in night mode
bc1e586 
The color set via textAppearance is overridden by any non-null
textColor set directly on the style. We always want the specific
properties the textAppearance specifies, so set them directly to
prevent them from being overridden.

#minor-release
Issue: google/ExoPlayer#9765
PiperOrigin-RevId: 414967143
ojw28 added a commit that referenced this issue Dec 10, 2021
@ojw28
Fix FFWD/RWND color in night mode
dff04b3 
The color set via textAppearance is overridden by any non-null
textColor set directly on the style. We always want the specific
properties the textAppearance specifies, so set them directly to
prevent them from being overridden.

#minor-release
Issue: #9765
PiperOrigin-RevId: 414967143
@ojw28 ojw28 closed this as completed Jan 4, 2022
@ojw28 ojw28 removed the needs triage label Jan 4, 2022
@google google locked and limited conversation to collaborators Mar 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ojw28 ojw28

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@tobiasKaminsky @ojw28 @google-oss-bot