Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update version 2.16.1 video can not play #9719

Closed
zhouzhengfw opened this issue Nov 23, 2021 · 5 comments
Closed

update version 2.16.1 video can not play #9719

zhouzhengfw opened this issue Nov 23, 2021 · 5 comments
Assignees
@kim-vde
Labels
bug

Comments

@zhouzhengfw
Copy link

hi after i update my version to 2.16.1 i can not play my video https://cdn1-staging.fireworktv.com/medias/2021/11/18/1637259506-rwyenuix/transcoded/540/LUDMILLAANTIRRACISTA.mp4
thank you
@tonihei
Copy link
Collaborator

tonihei commented Nov 25, 2021

Yes, I can confirm this file plays fine in 2.15.0 and fails to play in the latest dev version.

The error is:

Caused by: java.lang.IllegalStateException
        at androidx.media3.common.util.Assertions.checkState(Assertions.java:85)
        at androidx.media3.extractor.ParsableNalUnitBitArray.assertValidOffset(ParsableNalUnitBitArray.java:212)
        at androidx.media3.extractor.ParsableNalUnitBitArray.skipBit(ParsableNalUnitBitArray.java:68)
        at androidx.media3.extractor.ParsableNalUnitBitArray.readBit(ParsableNalUnitBitArray.java:128)
        at androidx.media3.extractor.ParsableNalUnitBitArray.readExpGolombCodeNum(ParsableNalUnitBitArray.java:196)
        at androidx.media3.extractor.ParsableNalUnitBitArray.readUnsignedExpGolombCodedInt(ParsableNalUnitBitArray.java:181)
        at androidx.media3.extractor.NalUnitUtil.parseH265SpsNalUnitPayload(NalUnitUtil.java:550)
        at androidx.media3.extractor.NalUnitUtil.parseH265SpsNalUnit(NalUnitUtil.java:456)
        at androidx.media3.extractor.HevcConfig.parse(HevcConfig.java:83)
        at androidx.media3.extractor.mp4.AtomParsers.parseVideoSampleEntry(AtomParsers.java:1152)
        at androidx.media3.extractor.mp4.AtomParsers.parseStsd(AtomParsers.java:952)
        at androidx.media3.extractor.mp4.AtomParsers.parseTrak(AtomParsers.java:311)
        at androidx.media3.extractor.mp4.AtomParsers.parseTraks(AtomParsers.java:132)
        at androidx.media3.extractor.mp4.Mp4Extractor.processMoovAtom(Mp4Extractor.java:491)
        at androidx.media3.extractor.mp4.Mp4Extractor.processAtomEnded(Mp4Extractor.java:450)
        at androidx.media3.extractor.mp4.Mp4Extractor.readAtomPayload(Mp4Extractor.java:432)
        at androidx.media3.extractor.mp4.Mp4Extractor.read(Mp4Extractor.java:250)

@kim-vde Could you take a look?

@kim-vde
Copy link
Contributor

kim-vde commented Nov 26, 2021

Thanks for reporting the issue. This is a regression introduced by #9421. I will merge a fix.

kim-vde added a commit that referenced this issue Nov 26, 2021
@kim-vde
Fix inconsistency with spec in H.265 SPS nal units parsing
dbec03b 
Issue: #9719

#minor-release

PiperOrigin-RevId: 412424558
@kim-vde
Copy link
Contributor

kim-vde commented Nov 26, 2021

I just merged the fix to dev-v2. It should be part of the next minor release.

I will close this issue. Please open another one if you still encounter problems.

@kim-vde kim-vde closed this as completed Nov 26, 2021
@rickzw
Copy link

rickzw commented Dec 1, 2021

I just merged the fix to dev-v2. It should be part of the next minor release.

I will close this issue. Please open another one if you still encounter problems.

When is the next minor release with this fix?

@kim-vde
Copy link
Contributor

kim-vde commented Dec 2, 2021

The next major release is planned for February or March 2022. We don't know yet if we are going to do a minor release before.

tonihei pushed a commit to androidx/media that referenced this issue Dec 2, 2021
@kim-vde @tonihei
Fix inconsistency with spec in H.265 SPS nal units parsing
f9d3bed 
Issue: google/ExoPlayer#9719

#minor-release

PiperOrigin-RevId: 412424558
@google google locked and limited conversation to collaborators Jan 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@kim-vde kim-vde

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@tonihei @kim-vde @rickzw @zhouzhengfw