Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IMA Extension support for client-side DAI #8213

Closed
adrianrdzv opened this issue Nov 12, 2020 · 5 comments
Closed

IMA Extension support for client-side DAI #8213

adrianrdzv opened this issue Nov 12, 2020 · 5 comments
Assignees
@tonihei
Labels
enhancement

Comments

@adrianrdzv
Copy link

Use case description

The IMA SDK now provides support for using dynamic ad insertion on the client
https://developers.google.com/interactive-media-ads/docs/sdks/android/dai
However, this requires to manipulate the AdsLoader. Currently the IMA Extension wraps the AdsLoader inside a ImaAdsLoader and would not be possible to request a Stream from it.

Alternatives considered

Currently the only alternative to use client side DAI is bypass IMA Extension and directly construct the AdsLoader ourselves.
@andrewlewis
Copy link
Collaborator

andrewlewis commented Nov 23, 2020 •
edited

The IMA extension only handles client-side ad insertion currently.

You can still use ExoPlayer as a player for DAI streams loaded by the IMA SDK, where your app interacts with the IMA SDK APIs directly (in this case the IMA extension isn't used at all). You'd need to write code to get the stream URL to play and propagate metadata events from the player.

I'll leave this open to track supporting DAI via the IMA SDK in the IMA extension (or a new extension), but marked as low priority as we aren't planning to work on it soon.

@victorraft
Copy link

Our company would very much appreciate if the Exo team implemented support for DAI!
We have lots of apps using DAI and just today we found errors in our DAI implementation that are causing a great deal of issues, and I guess this would not have happened if we had a reliable DAI implementation in the Exo SDK itself, so that's something I'd very much like to see in the future :)

@cadalt
Copy link

cadalt commented Feb 5, 2021

yes! support for dai!

@nishantkp
Copy link

This will be very much appreciated.
Support for DAI, way to go...

@tonihei tonihei assigned tonihei and unassigned andrewlewis May 17, 2021
andrewlewis pushed a commit to androidx/media that referenced this issue Feb 1, 2022
@icbaker @andrewlewis
Publish the ImaServerSideAdInsertionMediaSource
80c786b 
Issue: google/ExoPlayer#8213

#minor-release

PiperOrigin-RevId: 425381474
icbaker added a commit that referenced this issue Feb 2, 2022
@icbaker
Publish the ImaServerSideAdInsertionMediaSource
4020f69 
Issue: #8213

#minor-release

PiperOrigin-RevId: 425381474
icbaker added a commit that referenced this issue Feb 23, 2022
@icbaker
Publish the ImaServerSideAdInsertionMediaSource
e350f9c 
Issue: #8213

#minor-release

PiperOrigin-RevId: 425381474
icbaker added a commit to androidx/media that referenced this issue Feb 25, 2022
@icbaker
Publish the ImaServerSideAdInsertionMediaSource
e897608 
Issue: google/ExoPlayer#8213

#minor-release

PiperOrigin-RevId: 425381474
@marcbaechinger
Copy link
Contributor

The ImaServerSideAdInsertionMediaSoruce.Factory has been published with 2.17.0. The first release supports IMA streams for HLS/DASH VOD and HLS live.

https://exoplayer.dev/ad-insertion.html#ima-extension-1

@google google locked and limited conversation to collaborators May 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@tonihei tonihei

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
7 participants
@andrewlewis @marcbaechinger @victorraft @adrianrdzv @cadalt @tonihei @nishantkp