Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make DefaultTrackSelector prefer more efficient video codecs (everything else being equal) #4835

Closed
ojw28 opened this issue Sep 18, 2018 · 4 comments
Closed

Make DefaultTrackSelector prefer more efficient video codecs (everything else being equal) #4835

ojw28 opened this issue Sep 18, 2018 · 4 comments
Assignees
@ojw28
Labels
enhancement

Comments

@ojw28
Copy link
Contributor

ojw28 commented Sep 18, 2018

If there are multiple video TrackGroups that are roughly equivalent except for the codec used, DefaultTrackSelector should prefer to select the TrackGroup that uses the most efficient codec*.

  • An exception would be if a less efficient codec appears to have a hardware decoder, where-as the more efficient codec does not.
@ojw28 ojw28 self-assigned this Sep 18, 2018
@ojw28 ojw28 mentioned this issue Sep 18, 2018
Closed
@manishPatwari
Copy link

@ojw28 Hello, Any update on this?

@juechemparathy
Copy link

@ojw28 - Any updates on this? Thanks.

@ScottPierce
Copy link

Any update on this?

@kevinscroggins-youi
Copy link

Should in theory be able to work around this by hooking up the setPreferredAudio/VideoMimeType APIs on the DefaultTrackSelector.
https://exoplayer.dev/doc/reference/com/google/android/exoplayer2/trackselection/DefaultTrackSelector.ParametersBuilder.html#setPreferredVideoMimeType(java.lang.String)

tonihei added a commit that referenced this issue Jan 17, 2022
@tonihei
Limit adaptive selections to same level of decoder support
b3981be 
Adaptive video and audio selections will be limited to formats with
the same level of DecoderSupport and HardwareAccelatationSupport, unless
specifically allowed by new flags.

If different levels of decoder support are available, prefer primary
over fallback decoders and hardware-accelerated over software decoders
(in this order). For video, also prefer more efficient codecs, if both
are supported by hardware-accelerated primary decoders.

Issue: #4835
Issue: #9565
PiperOrigin-RevId: 422345048
@tonihei tonihei closed this as completed Jan 17, 2022
icbaker pushed a commit to androidx/media that referenced this issue Jan 26, 2022
@tonihei @icbaker
Limit adaptive selections to same level of decoder support
3cfd24a 
Adaptive video and audio selections will be limited to formats with
the same level of DecoderSupport and HardwareAccelatationSupport, unless
specifically allowed by new flags.

If different levels of decoder support are available, prefer primary
over fallback decoders and hardware-accelerated over software decoders
(in this order). For video, also prefer more efficient codecs, if both
are supported by hardware-accelerated primary decoders.

Issue: google/ExoPlayer#4835
Issue: google/ExoPlayer#9565
PiperOrigin-RevId: 422345048
@google google locked and limited conversation to collaborators Mar 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ojw28 ojw28

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@ScottPierce @juechemparathy @ojw28 @manishPatwari @tonihei @kevinscroggins-youi