Support key-frame accurate seeking in HLS #2882

mohammed-atif · 2017-05-29T15:44:04Z

SimpleExoPlayer.seekTo(int millis) issue

I have seen several issues requesting the same feature of smoother seeking in Exoplayer

At one thread I have seen your reply mentioning about the decoder but Android's VideoView default seeking is much more smoother when compared to ExoPlayer or MediaPlayer

Here is my code for reference

@Override
    public boolean onScroll(MotionEvent e1, MotionEvent e2, float distanceX, float distanceY) {
        long seekTo = (long) (mPlayer.getCurrentPosition() - distanceX);
        Log.d(TAG, "current scroll position "+seekTo);
        mPlayer.seekTo(seekTo);
        return true;
    }

I am using locally stored mp4 file to play using Exoplayer with TextureView

current exoplayer version - r2.4.1
com.google.android.exoplayer:exoplayer-core:r2.4.1

Are there any configurations that I have to change for smoother seeking?

The text was updated successfully, but these errors were encountered:

ojw28 · 2017-05-31T09:28:12Z

The reason behavior is different is that ExoPlayer does frame-accurate seeking (in all cases). I think VideoView does key-frame accurate seeking, which is faster but less accurate. We can use this issue to track supporting key-frame accurate seeking as an option, but it's low priority.

mohammed-atif · 2017-05-31T09:45:37Z

@ojw28 , In other players, we have a callback which notifies about the successful seeking. If I make multiple calls for seek using onScroll method, I can ignore the inputs if seek is in progress, but in case of ExoPlayer there is no such callback and due to multiple seek requests, the performance of seeking further goes down. It would be really good if ExoPlayer too provides the callbacks for seek completion.

Apart from that, as you mentioned about the key-frame seeking, can you provide me details about the class which I can look into to do minor tweaks at my end for better seeking?

goffioul · 2017-06-20T12:22:06Z

@atifmohammed Not sure this will help you, but I also needed some callback after seek completion. What I come up with was to drop a flag in my app when starting the seek operation, then listen to state change in onPlayerStateChanged. If my flag was set and the player state was STATE_READY, then I fired my callback. That seemed to work for my use case.

mohammed-atif · 2017-06-21T07:06:26Z

@goffioul Thanks for the response, I figured it out few days ago but couldn't update here. While seeking the state goes to Buffer and after seek it shifts to ready.

@ojw28 forward seek works good after adding the callbacks. But when I seek backwards, player's current time is not updated.

int currentTime =  mSimpleExoPlayer.getCurrentTime();
int seekToMillis = currentTime - 45; //seek duration is very small in the range of 30 to 60 milliseconds
mSimpleExoPlayer.seekTo(seekToMillis);

if seekToMillis is currentTime + duration then everything works good, but when seeking back, in STATE_READY, currentTime remains same after every seek action which causes back and forth jerk to the video. Is it avoidable by making any changes?

ojw28 · 2017-06-21T14:34:16Z

You shouldn't rely on the player reporting exactly your seek position back through getCurrentTime. The reported position may be adjusted slightly. If you want to seek in tiny increments like this, you should find a way to keep track of the last position that you performed a seek in your own code, and subtract 45 from that value each time. With that approach each position you pass to seekTo really will be 45 less than the previous value passed.

If we could keep this issue on topic, which is to support seeking to the nearest key-frame, that would be good. Thanks.

Issue: #2882 ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=177814974

Issue: #2882 ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=178370038

Issue: #2882 ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=178606133

Also fix ClippingMediaSource to consider the start position an artificial key-frame, and to properly offset the value returned by getAdjustedSeekPositionUs. Issue: #2882 ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=179032243

Whilst the previous behavior was WAI and had the advantage of updating the position to be more exact when known, there were a couple of disadvantages: 1. If seeking to the very end of a period in a playlist when paused, the position adjustment could trigger a position discontinuity to the next period. 2. We de-duplicate seeks to the current playback position. The position adjustment can prevent this from being effective. This is particularly important with the new SeekParameters support. When seeking to nearest sync point it's often possible to de-duplicate seeks, but we cannot do so if the playback position adjusts away from the sync point's time. Issue: #2439 Issue: #2882 ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=180540736

Issue: #2882 ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=181314086

green-nick · 2018-01-23T13:19:05Z

Hi, @ojw28
When we could see key-frame supporting on release? Will it be in 2.6.2?
Or does dev-branch stable enough?

This avoids issues that can arise due to slight discrepancies between chunk start times (obtained from the manifest of segment index) and the timestamps of the samples contained within those chunks. Issue: #2882 ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=182054959

ojw28 · 2018-01-23T20:02:18Z

It will be 2.7.0 (I'm not sure whether we're doing any further 2.6.x releases, but if we are they wont include the relevant changes). We don't have an ETA yet.

green-nick · 2018-01-23T20:59:43Z

@ojw28 Ok, thanks!

jclova · 2018-02-21T22:15:47Z

Really hoping to see the seekTo() options for us to choose:

Accurate/slow seek
To nearest keyframe/fast seek.

ojw28 · 2018-02-21T22:18:14Z

This is supported for all media types except HLS in 2.7.0, which will be released shortly, via ExoPlayer.setSeekParameters.

ojw28 · 2018-02-26T18:40:14Z

2.7.0 is now released, so this is now supported except for when playing HLS content.

jclova · 2018-02-26T19:02:33Z

Hooray!! Thank you so much for making the ExoPlayer awesome!

…

On Feb 26, 2018 1:40 PM, "ojw28" ***@***.***> wrote: 2.7.0 is now released. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#2882 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AMi04vWEUd3vscTuV6vfsh7gkisu-419ks5tYvqhgaJpZM4Npcbs> .

animaonline · 2018-08-27T19:41:25Z

When will this be support for HLS streams?

ojw28 · 2018-08-28T09:32:56Z

We do not have an ETA for supporting this for HLS.

BrainCrumbz · 2018-09-20T15:06:57Z

Hi all. Does anyone know how key-frame accurate seeking is reflected in SeekParameters "constants" (ref.)?

Which one should be passed to setSeekParameters() in order to achieve:

any frame accurate seeking
key-frame accurate seeking

?

TA

andrewlewis · 2018-09-20T15:12:28Z

@BrainCrumbz If you want to snap the seek position to the closest keyframe use SeekParameters.CLOSEST_SYNC. To see to a exact frame (the frame before the requested position, even if it's not a keyframe) use SeekParameters.EXACT.

BrainCrumbz · 2018-09-27T07:46:01Z

@ maintainers: would you consider a tiny PR over javadoc for those constants, to better clarify what each means? Not sure if e.g. "seeking to the closest sync point" fully clarifies that's a keyframe.

ojw28 · 2018-09-27T15:22:13Z

The documentation is deliberately vague, because exactly what happens depends a bit on the type of media being played. For DASH and SmoothStreaming, chunk boundaries are the sync points. If a chunk contains an additional keyframe somewhere in the middle, that's not considered as a sync point. For regular MP4, sync points are keyframes. For fragmented MP4, sync points are fragment boundaries.

The takeaway here is that sync points are whatever the underlying format naturally supports. A sync point will nearly always be aligned with a keyframe, but it's not necessarily true that all keyframes will be considered sync points.

tipoc123 · 2019-04-30T08:54:32Z

Do you have some enhancements for HLS seek? Current HLS seek is slow and not suitable for production use (ExoPlayer 2.9.6)

NathanSass · 2019-05-21T20:20:35Z

I agree. It would be great to see this scheduled ASAP

Zoeie · 2019-07-24T09:07:55Z

Like the MediaPlayer, it's just return the start position of the ts which the seek point owns to. The seeking operation is fast。
How should I modify the Exo source to be the same as the Seeking of MediaPlayer?

stevemayhew · 2021-05-11T23:49:34Z

@ojw28 and @AquilesCanta I'm looking at this now for I-Frame only playback. The issue there is when you scrub multiple i-Frames are loaded an discard before any first frame shows, so the delay runs into 100's of milliseconds depending on the network and size of i-Frames.

My plan is to implement something similar to DefaultDashChunkSource's method, getAdjustedSeekPositionUs() obviously the playlist would need to support and be marked with #EXT-X-INDEPENDENT-SEGMENTS for this to work. Also before / after tolerances less than a segment duration would not really work (as there is no way to know the GOP interval in the HLS segments data). For I-Frame only, this does not matter trivially as each segment contains only a single i-Frame.

Scrub seeking (like the original request is for) is best done in i-Frame mode, so we could restrict the getAdjustedSeekPositionUs() function to only adjust the position when the primary sample stream wrapper is I-frame only.

The HLS implementation of `getAdjustedSeekPositionUs()` now completely supports `SeekParameters.CLOSEST_SYNC` and it's brotheran, assuming the HLS stream indicates segments all start with an IDR (that is EXT-X-INDEPENDENT-SEGMENTS is specified). This fixes issue google#2882 and improves (but does not completely solve google#8592

jonas-livesporttv · 2022-02-23T14:50:14Z

@ojw28 you closing this issue means that key-frame accurate seeking in HLS is possible now?

ojw28 · 2022-02-23T14:52:54Z

I believe support was added by @stevemayhew in the merged pull requests referenced above.

ojw28 changed the title ~~SimpleExoPlayer.seekTo performance issue~~ Support key-frame accurate seeking May 31, 2017

ojw28 added the enhancement label May 31, 2017

ojw28 mentioned this issue Jun 20, 2017

Can we support seek options like SEEK_PREVIOUS_SYNC #2973

Closed

ojw28 mentioned this issue Oct 24, 2017

Faster seekto for exo player #3389

Closed

ojw28 self-assigned this Nov 19, 2017

ojw28 added a commit that referenced this issue Dec 4, 2017

Enhance SeekMaps to return SeekPoints

fbfa43f

Issue: #2882 ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=177814974

ojw28 added a commit that referenced this issue Dec 12, 2017

Public API for setting seek parameters

2b0b39c

Issue: #2882 ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=178370038

ojw28 added a commit that referenced this issue Dec 12, 2017

Expose ability to get adjusted seek position from MediaPeriod

2e3667e

Issue: #2882 ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=178606133

ojw28 mentioned this issue Jan 2, 2018

Is there a trick to speeding up buffering? #3651

Closed

ojw28 added a commit that referenced this issue Jan 15, 2018

Apply SeekParameters to DASH + SmoothStreaming playbacks

ff1bb2f

Issue: #2882 ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=181314086

AquilesCanta mentioned this issue Jan 18, 2018

Video reload #3720

Closed

google deleted a comment from KKXLC Feb 28, 2018

google deleted a comment from tonihei Feb 28, 2018

google deleted a comment from KKXLC Feb 28, 2018

google deleted a comment from andrewlewis Feb 28, 2018

ojw28 changed the title ~~Support key-frame accurate seeking~~ Support key-frame accurate seeking in HLS May 9, 2018

ojw28 mentioned this issue Nov 20, 2018

Question: How to improve HLS seek performance? #5127

Closed

Artiume mentioned this issue Feb 19, 2020

[Request] Document Playback Flow jellyfin-archive/jellyfin-docs#202

Open

ojw28 mentioned this issue Feb 16, 2021

Support renderer mode that only renders the first frame (for trick play) #8592

Open

stevemayhew mentioned this issue Oct 6, 2021

Implements SeekParameters.*_SYNC variants for HLS #9536

Merged

stevemayhew mentioned this issue Dec 8, 2021

Uses correct index for playlist URL #9767

Merged

mueslimak3r mentioned this issue Feb 15, 2022

only use HLS for live tv - otherwise use progressive mkv jellyfin/jellyfin-androidtv#1440

Closed

ojw28 closed this as completed Feb 23, 2022

google locked and limited conversation to collaborators Apr 25, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Support key-frame accurate seeking in HLS #2882

Support key-frame accurate seeking in HLS #2882

mohammed-atif commented May 29, 2017 •

edited

ojw28 commented May 31, 2017

mohammed-atif commented May 31, 2017

goffioul commented Jun 20, 2017

mohammed-atif commented Jun 21, 2017

ojw28 commented Jun 21, 2017 •

edited

green-nick commented Jan 23, 2018

ojw28 commented Jan 23, 2018

green-nick commented Jan 23, 2018

jclova commented Feb 21, 2018

ojw28 commented Feb 21, 2018 •

edited

ojw28 commented Feb 26, 2018 •

edited

jclova commented Feb 26, 2018 via email

animaonline commented Aug 27, 2018

ojw28 commented Aug 28, 2018

BrainCrumbz commented Sep 20, 2018

andrewlewis commented Sep 20, 2018 •

edited

BrainCrumbz commented Sep 27, 2018 •

edited

ojw28 commented Sep 27, 2018 •

edited

tipoc123 commented Apr 30, 2019 •

edited

NathanSass commented May 21, 2019

Zoeie commented Jul 24, 2019

stevemayhew commented May 11, 2021

jonas-livesporttv commented Feb 23, 2022 •

edited

ojw28 commented Feb 23, 2022

Support key-frame accurate seeking in HLS #2882

Support key-frame accurate seeking in HLS #2882

Comments

mohammed-atif commented May 29, 2017 • edited

SimpleExoPlayer.seekTo(int millis) issue

ojw28 commented May 31, 2017

mohammed-atif commented May 31, 2017

goffioul commented Jun 20, 2017

mohammed-atif commented Jun 21, 2017

ojw28 commented Jun 21, 2017 • edited

green-nick commented Jan 23, 2018

ojw28 commented Jan 23, 2018

green-nick commented Jan 23, 2018

jclova commented Feb 21, 2018

ojw28 commented Feb 21, 2018 • edited

ojw28 commented Feb 26, 2018 • edited

jclova commented Feb 26, 2018 via email

animaonline commented Aug 27, 2018

ojw28 commented Aug 28, 2018

BrainCrumbz commented Sep 20, 2018

andrewlewis commented Sep 20, 2018 • edited

BrainCrumbz commented Sep 27, 2018 • edited

ojw28 commented Sep 27, 2018 • edited

tipoc123 commented Apr 30, 2019 • edited

NathanSass commented May 21, 2019

Zoeie commented Jul 24, 2019

stevemayhew commented May 11, 2021

jonas-livesporttv commented Feb 23, 2022 • edited

ojw28 commented Feb 23, 2022

mohammed-atif commented May 29, 2017 •

edited

ojw28 commented Jun 21, 2017 •

edited

ojw28 commented Feb 21, 2018 •

edited

ojw28 commented Feb 26, 2018 •

edited

andrewlewis commented Sep 20, 2018 •

edited

BrainCrumbz commented Sep 27, 2018 •

edited

ojw28 commented Sep 27, 2018 •

edited

tipoc123 commented Apr 30, 2019 •

edited

jonas-livesporttv commented Feb 23, 2022 •

edited