Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RTSP error not handled by Listener.onPlayerError, app crashes on invalid media #10165

Closed
1 task
ArtRoman opened this issue Apr 7, 2022 · 2 comments
Closed
1 task

RTSP error not handled by Listener.onPlayerError, app crashes on invalid media #10165

ArtRoman opened this issue Apr 7, 2022 · 2 comments
Assignees
@claincly
Labels
bug

Comments

@ArtRoman
Copy link

ArtRoman commented Apr 7, 2022

ExoPlayer Version

2.17.1

Devices that reproduce the issue

Any device, I think.
Reproduces on emulator with Android 11 (R) and Asus Tinkerboard with Android 7 (N).

Devices that do not reproduce the issue

No response

Reproducible in the demo app?

Not tested

Reproduction steps

Start RTSP stream: rtsp://wowzaec2demo.streamlock.net/vod/mp4:BigBuckBunny_175k.mov
Stream is missing some data because server was about to close starting this year, but URL is still accessible.

Expected result

RTSP stream is missing some data, so playback should stop, ExoException should raise via onPlayerError(PlaybackException error) if listener is set

Actual result

App crashes with error in log tagged by AndroidRuntime:

 FATAL EXCEPTION: ExoPlayer:Playback
 Process: *****, PID: 29242
 java.lang.IllegalArgumentException
 	at com.google.android.exoplayer2.util.Assertions.checkArgument(Assertions.java:39)
 	at com.google.android.exoplayer2.source.rtsp.RtspSessionTiming.parseTiming(RtspSessionTiming.java:66)
 	at com.google.android.exoplayer2.source.rtsp.RtspClient$MessageListener.onDescribeResponseReceived(RtspClient.java:683)
 	at com.google.android.exoplayer2.source.rtsp.RtspClient$MessageListener.handleRtspResponse(RtspClient.java:598)
 	at com.google.android.exoplayer2.source.rtsp.RtspClient$MessageListener.handleRtspMessage(RtspClient.java:507)
 	at com.google.android.exoplayer2.source.rtsp.RtspClient$MessageListener.lambda$onRtspMessageReceived$0$com-google-android-exoplayer2-source-rtsp-RtspClient$MessageListener(RtspClient.java:500)
 	at com.google.android.exoplayer2.source.rtsp.RtspClient$MessageListener$$ExternalSyntheticLambda0.run(Unknown Source:4)
 	at android.os.Handler.handleCallback(Handler.java:938)
 	at android.os.Handler.dispatchMessage(Handler.java:99)
 	at android.os.Looper.loop(Looper.java:223)
 	at android.os.HandlerThread.run(HandlerThread.java:67)

RtspSessionTiming.java:66 is

      checkArgument(stopTimeMs > startTimeMs);

both values are set to 0.

Media

rtsp://wowzaec2demo.streamlock.net/vod/mp4:BigBuckBunny_175k.mov

Bug Report

  • You will email the zip file produced by adb bugreport to [email protected] after filing this issue.
@ojw28 ojw28 self-assigned this Apr 8, 2022
@ojw28 ojw28 assigned claincly and unassigned ojw28 Apr 19, 2022
@ojw28
Copy link
Contributor

ojw28 commented Apr 19, 2022

@claincly - Please take a look

@claincly
Copy link
Contributor

I can't connect to the link provided via both VLC and ExoPlayer. A fix is on the way.

icbaker pushed a commit that referenced this issue Apr 26, 2022
@claincly @icbaker
Catch unchecked exception in RtspSessionTiming parsing.
85bd080 
Issue: #10165
#minor-release
PiperOrigin-RevId: 443653894
icbaker pushed a commit to androidx/media that referenced this issue Apr 26, 2022
@claincly @icbaker
Catch unchecked exception in RtspSessionTiming parsing.
59ced53 
Issue: google/ExoPlayer#10165
#minor-release
PiperOrigin-RevId: 443653894
@ArtRoman ArtRoman closed this as completed Sep 2, 2022
@google google locked and limited conversation to collaborators Nov 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@claincly claincly

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ArtRoman @ojw28 @claincly