Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(curriculum): add animations to block 8.2 of the English Curriculum #55191

Merged
merged 2 commits into from
Jun 17, 2024
Merged

feat(curriculum): add animations to block 8.2 of the English Curriculum #55191

merged 2 commits into from
Jun 17, 2024

Conversation

miyaliu666
Copy link
Member

Checklist:

8-2-1

  • Task 8: incomplete "Absolutely" and "Node.js"
  • Task 9, task 10: incomplete "Absolutely"
  • Task 11, task 12: incomplete "Sure"

8-2-3

  • Task 27: incomplete "True"
  • Task 28: incomplete "effectively"

@github-actions github-actions bot added the scope: curriculum Lessons, Challenges, Projects and other Curricular Content in curriculum directory. label Jun 14, 2024
@miyaliu666 miyaliu666 changed the title add animations for 3 dialogues feat(curriculum): add animations to block 8.2 of the English Curriculum Jun 14, 2024
@miyaliu666 miyaliu666 added the new english course English Curriculum label Jun 14, 2024
DanielRosa74
DanielRosa74 approved these changes Jun 14, 2024
View reviewed changes
Copy link
Contributor

@DanielRosa74 DanielRosa74 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dialogues added, fixed an issue with task 20, and audio sync adjusted where pointed out. LGTM

@DanielRosa74 DanielRosa74 added the status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending. label Jun 14, 2024
@naomi-lgbt naomi-lgbt merged commit df2d52a into freeCodeCamp:main Jun 17, 2024
17 checks passed
@miyaliu666 miyaliu666 deleted the feat-8.2-dialogues branch June 19, 2024 04:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DanielRosa74 DanielRosa74 DanielRosa74 approved these changes

@naomi-lgbt naomi-lgbt naomi-lgbt approved these changes

Assignees
No one assigned
Labels
new english course English Curriculum scope: curriculum Lessons, Challenges, Projects and other Curricular Content in curriculum directory. status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@miyaliu666 @DanielRosa74 @naomi-lgbt