-
Notifications
You must be signed in to change notification settings - Fork 26.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Missing default context menu buttons on each platform #107578
Comments
Hi @justinmc, The ability to add custom buttons for app specific functionality should also be considered. For instance, Twitter has "mute" and "search" buttons which are app specific which can be seen when a text is selected. It'd be useful if the developer can add such buttons by providing a list of Strings and their respective callbacks. By the way, the table is missing some buttons for iOS and Android:
|
we are dealing with this now as well. |
The lack of buttons in text selection is critical for native like experience. In android, developers can add floating text selection toolbar actions that will show in every native app through the |
Other standard iOS options
The bigger issue here is not just to add the buttons. It's that the system itself provides them. If iOS 18 or Android 14 adds "ask ChatGPT" and "Generate AI video" and "find related photos" as standard options, it should not require every Flutter app in existance to rebuild with a newer version of flutter and re-go through the app-store approval process for that option to appear on the context menu. |
As an Android user I find the "Translate" button in particular to be extremely useful, any time I'm reading text in a language other than English. (Even if I know the language moderately well, I'll use it regularly for words and phrases I don't understand.) When it's missing in a given app, if it's any app that's heavy on reading text, I'll notice and it's disappointing. So as a developer I imagine many of my users value it too. I believe the "Translate" button is actually another example in this category, though (aka #107603):
in that I believe it's added by the Google Translate app. (Other translation apps like DeepL add their own text selection buttons, too.) So supporting this category would be especially appreciated. |
This issue is missing a priority label. Please set a priority label when adding the |
@justinmc Should this issue be considered an umbrella issue or moved to a project? I don't know that it is clear which team should own it. |
@mossmana I'm fine with design/text-input owning it. I think I would keep it as an umbrella issue. I'll update the title and add links to relevant PRs. |
In native iOS, users are able to select text and initiate a share menu, which provides several standard services, such as copy, sharing to social media, direct ability to send to various contacts through messaging apps, etc. https://github.com/flutter/engine/assets/36148254/d0af7034-31fd-412e-8636-a06bbff54765 This PR is the engine portion of the changes that will allow Share to be implemented This PR addresses flutter/flutter#107578 More details are available in this [design doc](https://github.com/flutter/engine/pull/flutter.dev/go/add-missing-features-to-selection-controls)
In native iOS, users are able to select text and initiate a share menu, which provides several standard services, such as copy, sharing to social media, direct ability to send to various contacts through messaging apps, etc. https://github.com/flutter/engine/assets/36148254/d0af7034-31fd-412e-8636-a06bbff54765 This PR is the framework portion of the changes that will allow Share to be implemented. The corresponding merged engine PR is [here](flutter/engine#44554) This PR addresses #107578 More details are available in this [design doc](https://github.com/flutter/engine/pull/flutter.dev/go/add-missing-features-to-selection-controls)
In native iOS, users are able to select text and initiate a share menu, which provides several standard services, such as copy, sharing to social media, direct ability to send to various contacts through messaging apps, etc. https://github.com/flutter/engine/assets/36148254/d0af7034-31fd-412e-8636-a06bbff54765 This PR is the engine portion of the changes that will allow Share to be implemented This PR addresses flutter/flutter#107578 More details are available in this [design doc](https://github.com/flutter/engine/pull/flutter.dev/go/add-missing-features-to-selection-controls)
This issue is assigned to @LouiseHsu but has had no recent status updates. Please consider unassigning this issue if it is not going to be addressed in the near future. This allows people to have a clearer picture of what work is actually planned. Thanks! |
This issue is assigned to @LouiseHsu but has had no recent status updates. Please consider unassigning this issue if it is not going to be addressed in the near future. This allows people to have a clearer picture of what work is actually planned. Thanks! |
By default, Flutter's text selection toolbar shows cut, copy, paste, and select all. However, on native platforms, other buttons appear by default.
Custom buttons: #139361
Open questions
How about buttons inserted by the system, such as the Anki Card button in my Android screenshot added by the AnkiDroid app? (edit: -> #107603)
Related
#82907
The text was updated successfully, but these errors were encountered: