Use trigger.entryPoint instead of trigger.name #4174
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit ca6d63d.
taeold
reviewed
Feb 17, 2022
|
Good call! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixed the errors that arose when merging in the Function emulator changes from master. PTAL at the second commit by itself here - that is the actual code that I needed to change to get this working.
The problem was that #4149 subtly changed the behavior of the function emulator. Previous, we looked for the functions code at
EmulatedTriggerDefinition.entryPoint. After those changes, we started looking for the functions code atEmulatedTriggerDefinition.name. AFAICT these are always the same value for CF3, but for extensions, they are always different.Scenarios Tested
I can now successfuly execute functions with running into the "Failed to initialize and load trigger. This shouldn't happen: Failed to find function ext.httptest.greetTheWorld in the loaded module" error.