Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improves login experience when no localhost is available. #4147

Merged
merged 13 commits into from
Feb 10, 2022
Merged

Improves login experience when no localhost is available. #4147

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
fae0ebe
Proof-of-concept for signing in remotely via auth proxy server.
mbleigh Dec 8, 2021
bab40ab
Fix lint error
mbleigh Dec 8, 2021
d69072d
Update output of --remote
mbleigh Jan 12, 2022
b97c033
Merge branch 'master' of github.com:firebase/firebase-tools into mb-a…
mbleigh Jan 24, 2022
8c35187
Merge branch 'master' of github.com:firebase/firebase-tools into mb-a…
mbleigh Jan 30, 2022
f0cc174
Replace --no-localhost with remote login.
mbleigh Feb 2, 2022
716d58a
Remove vestiges of --remote
mbleigh Feb 2, 2022
5b569c5
Merge branch 'master' into mb-authproxy
mbleigh Feb 4, 2022
260b85d
CHANGELOG, fixes emu test.
mbleigh Feb 4, 2022
6cc1b64
Fix track import.
mbleigh Feb 7, 2022
0f81c62
Wrap auth code error in better message.
mbleigh Feb 7, 2022
a84269c
Merge branch 'master' into mb-authproxy
mbleigh Feb 9, 2022
4435b4a
Merge branch 'master' into mb-authproxy
bkendall Feb 10, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix lint error
  • Loading branch information
@mbleigh
mbleigh committed Dec 8, 2021
commit bab40ab29e272b88c0ce0bd8211013b9ff952f9e
2 changes: 1 addition & 1 deletion src/auth.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -431,7 +431,7 @@ async function loginRemotely(userHint?: string): Promise<UserCredentials> {
const sessionId = uuidv4();
const codeVerifier = randomBytes(32).toString("hex");
// urlsafe base64 is required for code_challenge in OAuth PKCE
let codeChallenge = urlsafeBase64(createHash("sha256").update(codeVerifier).digest("base64"));
const codeChallenge = urlsafeBase64(createHash("sha256").update(codeVerifier).digest("base64"));

const attestToken = (
await authProxyClient.post<{ session_id: string }, { token: string }>("/attest", {
Expand Down