Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixes hosting:channel:create when providing an ID #3436

Merged
merged 5 commits into from
Jun 1, 2021
Merged

fixes hosting:channel:create when providing an ID #3436

merged 5 commits into from
Jun 1, 2021

Conversation

bkendall
Copy link
Contributor

@bkendall bkendall commented Jun 1, 2021

Description

hosting:channel:create was ignoring a provided channel ID. See #3417

Scenarios Tested

» firebase hosting:channel:create -e 1h wefj1234

✔  hosting:channel: Channel wefj1234 has been created on site --.
✔  hosting:channel: Channel wefj1234 will expire at 2021-06-01 10:17:11.
✔  hosting:channel: Channel URL: https://----wefj1234-hbatjpdi.web.app

To deploy to this channel, use firebase hosting:channel:deploy wefj1234.
» firebase hosting:channel:create -e 1h
? Please provide a URL-friendly name for the channel: lfio34

✔  hosting:channel: Channel lfio34 has been created on site --.
✔  hosting:channel: Channel lfio34 will expire at 2021-06-01 10:17:17.
✔  hosting:channel: Channel URL: https://----lfio34-xwh9jrwn.web.app

To deploy to this channel, use firebase hosting:channel:deploy lfio34.

@bkendall bkendall requested review from inlined and joehan June 1, 2021 16:20
@google-cla google-cla bot added the cla: yes Manual indication that this has passed CLA. label Jun 1, 2021
@bkendall bkendall merged commit c17f208 into master Jun 1, 2021
@bkendall bkendall deleted the b3417 branch June 1, 2021 17:42
devpeerapong pushed a commit to devpeerapong/firebase-tools that referenced this pull request Dec 14, 2021
@bkendall @joehan @devpeerapong
fixes hosting:channel:create when providing an ID (firebase#3436)
1b87120 
* fixes hosting:channel:create when providing an ID

* formatting is hard

* better logic

Co-authored-by: joehan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@inlined inlined inlined approved these changes

@joehan joehan joehan approved these changes

Assignees
No one assigned
Labels
cla: yes Manual indication that this has passed CLA.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bkendall @inlined @joehan