Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Preserve existing environment variables when deploying functions. #3266

Merged
merged 1 commit into from
Apr 8, 2021
Merged

Preserve existing environment variables when deploying functions. #3266

merged 1 commit into from
Apr 8, 2021

Conversation

taeold
Copy link
Contributor

@taeold taeold commented Apr 7, 2021

Description

Today, we unexpectedly delete environment variables on existing Cloud Functions when updating functions via firebase deploy --only functions command #3226. This regression was introduced in #3132.

Scenarios Tested

  1. Manually setup an environment variable using Google Cloud Console on a firebase function.
  2. Run firebase deploy --only functions to update the existing function.
  3. Notice that existing environment variable isn't wiped out as a result of the new deploy.

@taeold taeold requested a review from joehan April 7, 2021 23:48
@google-cla google-cla bot added the cla: yes Manual indication that this has passed CLA. label Apr 7, 2021
@taeold taeold requested review from inlined and mbleigh April 8, 2021 15:59
@taeold taeold merged commit 341cdcd into master Apr 8, 2021
@taeold taeold deleted the dl-fn-envs branch April 8, 2021 16:15
@taeold taeold mentioned this pull request Apr 8, 2021
Closed
devpeerapong pushed a commit to devpeerapong/firebase-tools that referenced this pull request Dec 14, 2021
@taeold @devpeerapong
Preserve existing environment variables when deploying functions. (fi…
d21699b 
…rebase#3266)

Today, we unexpectedly delete environment variables on existing Cloud Functions when updating functions via `firebase deploy --only functions` command firebase#3226. This regression was introduced in firebase#3132.

### Scenarios Tested
1. Manually setup an environment variable using Google Cloud Console on a firebase function.
2. Run `firebase deploy --only functions` to update the existing function.
3. Notice that existing environment variable isn't wiped out as a result of the new deploy.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@inlined inlined inlined approved these changes

@joehan joehan Awaiting requested review from joehan

@mbleigh mbleigh Awaiting requested review from mbleigh

Assignees
No one assigned
Labels
cla: yes Manual indication that this has passed CLA.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@taeold @inlined