Ensure function URLs are printed even if other functions error(#3137) #3148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r slow function deployments
samtstern
approved these changes
Feb 19, 2021
|
Huge +1 for this. Over here in London with my slow internet my functions deploys take ~3m on average and ~5m+ on a bad day, this will save me a lot of headaches. |
devpeerapong
pushed a commit
to devpeerapong/firebase-tools
that referenced
this pull request
Dec 14, 2021
…r slow function deployments (firebase#3148)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Increasing operation poller timeout to prevent unexpected behavior for slow function deployments (see #3137).
Additionally, in release.ts, I moved the call to printTriggerUrls to before the call to printErrors, to ensure that it gets called even if some functions experience errors.