Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix(function deployment on Node v15.8.0) Bumped to archiver v5 from v3 #3135

Closed
wants to merge 2 commits into from
Closed

Conversation

alsohas
Copy link

@alsohas alsohas commented Feb 13, 2021

Description

Fixes #3120

Function deployment was failing on latest version of Node (as of writing). Migrating from archiver v3 to v5 seems to solve the issue.
The root cause was related to archiverjs/node-archiver#491 and nodejs/node#37027

Breaking changes in archiver v4 was:
breaking: remove support for versions under 8.

And v5 was:
breaking: absolute path glob patterns are no longer supported: use cwd option instead.

Neither of which effects this repo as far as I can tell.

Scenarios Tested

I tested function deployments on Node v10.13, v12, v14, and v15.8.0

Sample Commands

N/A

@google-cla
Copy link

google-cla bot commented Feb 13, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added the cla: no label Feb 13, 2021
@alsohas
Copy link
Author

alsohas commented Feb 13, 2021

@googlebot I signed it!

@google-cla
Copy link

google-cla bot commented Feb 13, 2021

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@alsohas alsohas closed this Feb 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Function deployment fails when running on Node 15.8.0
1 participant