Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Major refactor of functions deploy #3132

Merged
merged 37 commits into from
Feb 16, 2021
Merged

Major refactor of functions deploy #3132

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
37 commits
Select commit Hold shift + click to select a range
06b62a1
Adding onPoll option to operation-poller (#3046)
joehan Jan 19, 2021
6258dd5
Typescriptify functionsDeployHelper (#3059)
joehan Jan 20, 2021
ec7d079
Typescriptifying gcp.cloudfunctions (#3060)
joehan Jan 20, 2021
f583ef6
Typescriptifying functionsConfig (#3063)
joehan Jan 21, 2021
08b9d56
Typescriptifying deploymentTool (#3061)
joehan Jan 21, 2021
b4944a4
Refactoring prepare stage of functions deploy (#3067)
joehan Jan 21, 2021
3be0dca
refactoring release step of functions deploy to use typescript
joehan Jan 21, 2021
e0e703e
Adding logic to build regional deployments
joehan Jan 24, 2021
046c7d7
Implementing createDeploymentPlan
joehan Jan 26, 2021
b876523
First round of PR feedback, removing most usages of lodash
joehan Jan 28, 2021
9e0e6e9
moving function prompts into their own file
joehan Jan 28, 2021
2a3b547
seperating out a bunch of code from functionsDeployHelper
joehan Jan 28, 2021
51f2395
Resolves merge conflicts
joehan Jan 28, 2021
30cc0e9
refactoring release step of functions deploy to use typescript (#3071)
joehan Feb 1, 2021
6916000
Implements core logic of running function deploys
joehan Feb 1, 2021
3c8d4a0
Typescriptifying prepareFunctionsUpload (#3064)
joehan Feb 1, 2021
11956fa
Implementing createDeploymentPlan (#3081)
joehan Feb 1, 2021
85d0afe
adding timing and logs for deployments
joehan Feb 2, 2021
00b1989
cleaning up unused code
joehan Feb 2, 2021
397d7c4
Fixing some things that were broken while merging
joehan Feb 3, 2021
21f4906
Fixing up the order of wait and close to ensure that queue promsies a…
joehan Feb 4, 2021
3b3edbd
Format and clean up typos
joehan Feb 4, 2021
e428bcb
refactoring error handling to be cleaner
joehan Feb 5, 2021
4c8e2fb
cleaning up extera newlines
joehan Feb 8, 2021
7f48130
first round of pr fixes
joehan Feb 9, 2021
39a7e86
Readding some changes that I accidenttally wiped out during a merge
joehan Feb 9, 2021
1366955
Switching name to id where appropriate
joehan Feb 9, 2021
7513229
fixing another bug caused by functionName vs Id
joehan Feb 9, 2021
8d3d82d
Merge pull request #3107 from firebase/jh-execute-deployment-plans
joehan Feb 9, 2021
6d2260e
Refactor functions-delete (#3110)
joehan Feb 9, 2021
42e6c15
Cleaning up error reporting
joehan Feb 10, 2021
e4ce126
Merge remote-tracking branch 'public/master' into jh-functions-refactor
joehan Feb 10, 2021
12a48ea
Merge remote-tracking branch 'public/master' into jh-functions-refactor
joehan Feb 11, 2021
7cfe9d9
Implement validation for changing trigger types, and fixes from bug b…
joehan Feb 12, 2021
5eb08bd
Merge branch 'master' into jh-functions-refactor
joehan Feb 12, 2021
5ca6bbf
Merge branch 'master' into jh-functions-refactor
joehan Feb 16, 2021
344b674
fixes package.json
joehan Feb 16, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
Prev Previous commit
Next Next commit
cleaning up extera newlines
  • Loading branch information
@joehan
joehan committed Feb 8, 2021
commit 4c8e2fb5715098972c1186efd0dc6181f3b0539e
12 changes: 6 additions & 6 deletions src/deploy/functions/errorHandler.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,11 +40,11 @@ export class ErrorHandler {
if (this.errors.length === 0) {
return;
}
logger.info("\n\nFunctions deploy had errors with the following functions:");
logger.info("\nFunctions deploy had errors with the following functions:");
for (const failedDep of this.errors) {
logger.info(`\t${failedDep.functionName}`);
}
logger.info("\n\nTo try redeploying those functions, run:");
logger.info("\nTo try redeploying those functions, run:");
logger.info(
" " +
clc.bold("firebase deploy --only ") +
Expand All @@ -56,7 +56,7 @@ export class ErrorHandler {
) +
clc.bold('"')
);
logger.info("\n\nTo continue deploying other features (such as database), run:");
logger.info("\nTo continue deploying other features (such as database), run:");
logger.info(" " + clc.bold("firebase deploy --except functions"));
// Print all the original messages at debug level.
for (const failedDep of this.errors) {
Expand All @@ -73,13 +73,13 @@ export class ErrorHandler {
}
const failedIamCalls = this.warnings.filter((e) => e.operationType === "make public");
if (failedIamCalls.length) {
logger.info("\n\nUnable to set publicly accessible IAM policy on the following functions:");
logger.info("\nUnable to set publicly accessible IAM policy on the following functions:");
for (const failedDep of failedIamCalls) {
logger.info(`\t${failedDep.functionName}`);
}
logger.info("\n\nUnauthorized users will not be able access this function.");
logger.info("\nUnauthorized users will not be able access this function.");
logger.info(
"\n\nThis may be caused by an organization policy that restricts Network Access on your project."
"\nThis may be caused by an organization policy that restricts Network Access on your project."
);
}

Expand Down
5 changes: 1 addition & 4 deletions src/deploy/functions/tasks.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -228,10 +228,7 @@ export function deleteScheduleTask(
}

/**
*
* @param params
* @param regionalDeployment
* @param queue
* Adds tasks to execute all function creates and updates for a region to the provided queue.
*/
export function runRegionalFunctionDeployment(
params: TaskParams,
Expand Down