Convert FirebaseError to TypeScript #1521
Conversation
|
@bkendall This should now be ready for another review. |
|
@bkendall This should now be ready for another review. I'm pinging you because I can't request a review on GitHub as I don't have permissions, is it fine with you? Maybe you prefer some other way? |
|
@merlinnot in the top right of the PR view, is there not a little circle to click to re-request a review? That would make me sad if that's the case... replying to the PR is fine as it puts it into my email and that puts it into my heap of things to do :)
|
https://help.github.com/en/articles/requesting-a-pull-request-review Dang. That's sad. Replying is fine, I'll get to them! (Though, disclosure, no timeframe is guaranteed and I have other things to get done as well, so know that it's usually somewhere in my heap but other things can take priority...) |
|
No worries, I totally understand :) I'll also ping |
|
@bkendall And a friendly ping to make sure it ends up in your inbox :) |
Description
This PR coverts an existing
FirebaseErrorutility from JavaScript to TypeScript. It also changes the way it's exported, where it's now a named export.This PR is split in two commits for easier review: one with implementation and one with conversion to named imports.
Documentation of fields and interfaces is not added. I was willing to do so, but unfortunately it wasn't really clear to me what most of the options mean. It was not documented previously, so it's not a regression, so I hope it won't be a blocker for this PR and someone with a better understanding of the codebase could help with this. Since I don't understand the meaning of some of the properties, I didn't rename any fields, that would be a material for a separate PR anyway.
Scenarios Tested
Only unit tests.
Sample Commands
Not relevant.