Add ingress settings support in firebase functions (#2924)

Co-authored-by: joehan <[email protected]>
firebase · Jan 12, 2021 · fca0381 · fca0381
1 parent 67cff84
commit fca0381
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 0 deletions.
diff --git a/src/deploy/functions/release.js b/src/deploy/functions/release.js
@@ -262,6 +262,7 @@ module.exports = function (context, options, payload) {
  vpcConnector: functionInfo.vpcConnector,
  vpcConnectorEgressSettings: functionInfo.vpcConnectorEgressSettings,
  serviceAccountEmail: functionInfo.serviceAccountEmail,
+ ingressSettings: functionInfo.ingressSettings,
  })
  .then((createRes) => {
  if (_.has(functionTrigger, "httpsTrigger")) {
@@ -311,6 +312,7 @@ module.exports = function (context, options, payload) {
  vpcConnector: functionInfo.vpcConnector,
  vpcConnectorEgressSettings: functionInfo.vpcConnectorEgressSettings,
  serviceAccountEmail: functionInfo.serviceAccountEmail,
+ ingressSettings: functionInfo.ingressSettings,
  environmentVariables: _.assign(
  {},
  existingFunction.environmentVariables,

diff --git a/src/gcp/cloudfunctions.js b/src/gcp/cloudfunctions.js
@@ -99,6 +99,9 @@ function _createFunction(options) {
  if (options.serviceAccountEmail) {
  data.serviceAccountEmail = options.serviceAccountEmail;
  }
+ if (options.ingressSettings) {
+ data.ingressSettings = options.ingressSettings;
+ }
 
  return api
  .request("POST", endpoint, {
@@ -205,6 +208,10 @@ function _updateFunction(options) {
  data.serviceAccountEmail = options.serviceAccountEmail;
  masks.push("serviceAccountEmail");
  }
+ if (options.ingressSettings) {
+ data.ingressSettings = options.ingressSettings;
+ masks.push("ingressSettings");
+ }
  if (options.trigger.eventTrigger) {
  masks = _.concat(
  masks,