fix database:settings:get/set (#2811)

* fix settings:get/set * changelog * formatting is hard
firebase · Nov 11, 2020 · d305caf · d305caf
1 parent cd6e7ef
commit d305caf
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 1 deletion.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -0,0 +1 @@
+- Fixes issue in `database:settings:get` where the value wasn't being properly displayed.
diff --git a/src/apiv2.ts b/src/apiv2.ts
@@ -245,7 +245,7 @@ export class Client {
  method: options.method,
  };
 
- if (options.json) {
+ if (options.json !== undefined) {
  fetchOptions.body = JSON.stringify(options.json);
  }
 

diff --git a/src/commands/database-settings-get.ts b/src/commands/database-settings-get.ts
@@ -44,6 +44,12 @@ export default new Command("database:settings:get <path>")
  original: err,
  });
  }
+ // strictTriggerValidation returns an object, not a single string.
+ // Check for an object and get the `value` from it.
+ if (typeof res.body === "object") {
+ // eslint-disable-next-line @typescript-eslint/no-explicit-any
+ res.body = (res.body as any).value;
+ }
  utils.logSuccess(`For database instance ${options.instance}\n\t ${path} = ${res.body}`);
  }
  );