Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix a typo in the webchannel-wrapper's package.json. #8331

Merged
merged 2 commits into from
Jun 24, 2024

Conversation

ehsannas
Copy link
Contributor

@ehsannas ehsannas commented Jun 21, 2024

Fixes a typo in the webchannel-wrapper's package.json that affected ems5 exports.

@ehsannas ehsannas requested a review from hsubox76 June 21, 2024 20:52
@ehsannas ehsannas requested review from a team as code owners June 21, 2024 20:52
Copy link

changeset-bot bot commented Jun 21, 2024

🦋 Changeset detected

Latest commit: 082337f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@firebase/webchannel-wrapper Patch
@firebase/firestore Patch
firebase Patch
@firebase/firestore-compat Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Jun 21, 2024

Changeset File Check ✅

  • No modified packages are missing from the changeset file.
  • No changeset formatting errors detected.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jun 21, 2024

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jun 21, 2024

Copy link
Contributor

@DellaBitta DellaBitta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a changeset with the public release note. Thanks!

@ehsannas ehsannas requested a review from a team as a code owner June 24, 2024 18:16
@ehsannas ehsannas requested a review from DellaBitta June 24, 2024 18:17
Copy link
Contributor

@DellaBitta DellaBitta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also add a PR description. Could be the same text as the changeset. Thanks!

@ehsannas
Copy link
Contributor Author

Done.

@ehsannas ehsannas merged commit b09a267 into master Jun 24, 2024
42 checks passed
@ehsannas ehsannas deleted the ehsann/fix-webchannel-wrapper-typo branch June 24, 2024 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants